Skip to content

[CU-86e1kwwx0]: don't console.log #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrManini merged 2 commits into from
May 30, 2026
Merged

[CU-86e1kwwx0]: don't console.log #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2d9249
[CU-86e1kwwx0]: don't console.log
WilmerJr01 May 29, 2026
9a31b37
[CU-86e1kwwx0]: Select all projects
WilmerJr01 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 3 additions & 39 deletions apps/gateway/src/modules/evaluations/evaluations.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,7 @@ export class EvaluationsService implements OnModuleInit {
return { items: [], courseId, eventId };
}

console.log(
`1. Found ${allProjects.length} projects for course ${courseId} in event ${eventId}`,
);
const projectIds = allProjects.map((p) => p.id);
console.log(
`2. Project IDs for course ${courseId} in event ${eventId}: ${projectIds.join(', ')}`,
);

// 2. Get evaluation statistics for these projects from evaluation service
const response: GetTopProjectsByCourseResponse = await lastValueFrom(
Expand All @@ -220,15 +214,9 @@ export class EvaluationsService implements OnModuleInit {
this.tieBreakService.listTieBreaks({ eventId, categoryId: courseId }),
);
appliedTiebreaks = tiebreaksResponse.tiebreaks ?? [];
console.log(
`3. Applied tiebreaks: ${appliedTiebreaks.length} for course ${courseId} in event ${eventId}`,
);
const tiebreakMap = new Map<number, number>(
appliedTiebreaks.map((tb) => [tb.projectId, tb.tiebreakOrder]),
);
console.log(
`4. Tiebreak map for course ${courseId} in event ${eventId}: ${[...tiebreakMap.entries()].map(([pid, order]) => `Project ${pid}: Order ${order}`).join(', ')}`,
);
sorted.sort((a, b) => {
if (b.averageGrade !== a.averageGrade)
return b.averageGrade - a.averageGrade;
Expand All @@ -239,23 +227,17 @@ export class EvaluationsService implements OnModuleInit {
});
}

console.log(
`5. Sorted projects by average grade${hasTies ? ' with tiebreaks applied' : ''} for course ${courseId} in event ${eventId}`,
);
const tiebreakProjectIds = new Set(
appliedTiebreaks.map((tb) => tb.projectId),
);
console.log(
`6. Projects with tiebreaks for course ${courseId} in event ${eventId}: ${[...tiebreakProjectIds].join(', ')}`,
);

const topProjects = sorted.slice(0, limit);
const sizeReal = limit || sorted.length;
const topProjects = sorted.slice(0, sizeReal);

// Detect disputed: projects outside the limit tied with the last position and without a tiebreak record
const disputedStats =
topProjects.length > 0
? sorted
.slice(limit)
.slice(sizeReal)
.filter(
(p) =>
p.averageGrade ===
Expand All @@ -265,17 +247,8 @@ export class EvaluationsService implements OnModuleInit {
: [];

// 4. Fetch full project details for the top N and disputed projects in parallel
console.log(
`7. Fetching full project details for top ${topProjects.length} projects and ${disputedStats.length} disputed projects for course ${courseId} in event ${eventId}`,
);
const topProjectIds = topProjects.map((tp) => tp.projectId);
console.log(
`8. Top project IDs: ${topProjectIds.join(', ')} for course ${courseId} in event ${eventId}`,
);
const disputedProjectIds = disputedStats.map((dp) => dp.projectId);
console.log(
`9. Disputed project IDs: ${disputedProjectIds.join(', ')} for course ${courseId} in event ${eventId}`,
);

const [projectsResponses, disputedResponses] = await Promise.all([
Promise.all(
Expand All @@ -294,9 +267,6 @@ export class EvaluationsService implements OnModuleInit {
),
]);

console.log(
`10. Fetched project responses for course ${courseId} in event ${eventId}`,
);
const buildEnrichedProject = (
tp: { projectId: number; averageGrade: number; evaluationCount: number },
response: any,
Expand Down Expand Up @@ -327,9 +297,6 @@ export class EvaluationsService implements OnModuleInit {
const enrichedProjects = topProjects
.map((tp, idx) => buildEnrichedProject(tp, projectsResponses[idx]))
.filter((p) => p !== null);
console.log(
`11. Enriched top projects for course ${courseId} in event ${eventId}: ${enrichedProjects.length}`,
);
const disputedProjects = disputedStats
.map((dp, idx) => buildEnrichedProject(dp, disputedResponses[idx]))
.filter((p) => p !== null);
Expand All @@ -338,9 +305,6 @@ export class EvaluationsService implements OnModuleInit {
const relevantTiebreaks = appliedTiebreaks.filter((tb) =>
enrichedProjectIds.has(tb.projectId),
);
console.log(
`12. Relevant tiebreaks for course ${courseId} in event ${eventId}: ${relevantTiebreaks.length}`,
);

return {
items: enrichedProjects,
Expand Down
Loading