Repository navigation
Conversation
…ure test The store writes each command to <id>.json.<uuid>.tmp and renames it. The test took the first directory entry, so a read during that window answered a temporary name and the request timed out with "was not applied by the desktop app". Filter to .json names, as the test's own helper already does. Under 32-way parallel load the old test failed 4 of 64 runs and the new one 0 of 64. Signed-off-by: Tim Nunamaker <tnunamak@gmail.com> Assisted-by: AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failed native result is rejected for that commandinreference-implementation/test/autostart-store.test.tsfails intermittently in CI with "Autostart change was not applied by the desktop app within 0.5s" (seen on #577 and #585 on 2026-10-23).The store writes each command to
<id>.json.<uuid>.tmpand then renames it (server/autostart-store.ts:69-71). The test took the first directory entry without filtering, so a read during that window picked the temporary name, answered the wrong command id, and the request timed out. The test now reads only.jsonnames, as itscommands()helper already does.Under 32-way parallel load the old test failed 4 of 64 runs and the new one 0 of 64. Test-only change.
Assisted-by: AI