Repository navigation
refactor(browser): stop writing the unused surface retention flag - #613
Merged
tnunamak merged 2 commits intoOct 29, 2026
Merged
Conversation
Managed browser sessions no longer use process retention. Remove that flag from SQLite and PostgreSQL writes while keeping existing database schemas and historical values intact. Tests save and reload sessions without the column on both databases. A SQLite restart test confirms idle cleanup of historical retained rows. Assisted-by: AI Signed-off-by: Tim Nunamaker <tnunamak@gmail.com>
Assisted-by: AI Signed-off-by: Tim Nunamaker <tnunamak@gmail.com>
Base automatically changed from
retention/trust-postgres-cleanup-20261029
to
main
October 29, 2026 16:29
tnunamak
deleted the
retention/remove-obsolete-surface-writer-20261029
branch
October 29, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The store for managed browser sessions still writes a retention flag that the runtime no longer uses.
Both database implementations in
reference-implementation/server/stores/browser-surface-lease-store.ts, which persists managed browser sessions, now write only the metadata they use. Existing databases retain the obsolete column and its historical values, so this cleanup introduces no schema migration.Tests write and read a session from tables missing that column on the SQLite and PostgreSQL databases. They also reopen a historical retained row and verify idle cleanup still stops its browser. Full memory and PostgreSQL runs passed before a test-only setup-cleanup adjustment; the affected store/controller tests and static type checks also pass after that adjustment. Current-head CI is pending.
Replaying the old store makes the missing-column tests fail on both databases. The automated fault-injection sampler could not select a trial within its 60-line, eight-test-file budget; this is missing sampler evidence, not a passing mutation result.
Assisted-by: AI