There was a bug with the velocity normalisation in the supg example i…#187
Merged
stevendargaville merged 5 commits intomainfrom Feb 18, 2026
Merged
There was a bug with the velocity normalisation in the supg example i…#187stevendargaville merged 5 commits intomainfrom
stevendargaville merged 5 commits intomainfrom
Conversation
…n 3D. Also changed the default velocity direction in both the dg and supg tests in 3D to 1,1,1 normalised. Can restore original behaviour with -u 1 -v 1 -w 0 -unit_velocity 1.
…of u,v,w so it automatically normalises
…oesn't have to specify them on the command line any longer
…ests. Also updated some comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n 3D. Also changed the default velocity direction in both the dg and supg tests in 3D to 1,1,1 normalised. Can restore original behaviour with -u 1 -v 1 -w 0 -unit_velocity 1. Also added -bottom_only_inflow_one option to supg test.