docs: remove stale AutoMapper references (#241) - #381
Merged
Conversation
AutoMapper was dropped in v2.6.0 (#173) in favour of manual mapping extensions, but four docs pages still described it as the live mapping layer -- architecture/backend.md even carried a .ForAllMembers snippet that exists nowhere in the codebase. The mapping sections in architecture/overview.md and architecture/backend.md now describe AlarmMappingExtensions (To*() / ApplyUpdate()) and EntityMappingExtensions (ToModel() / ToEntity() / ApplyTo()), with a real ApplyUpdate snippet showing the explicit null-skip guards. The Core.Mappings/ line in the solution tree, the test-coverage bullet in development/testing.md, and a passing mention in architecture/poracleng-proxy.md are corrected to match. Also renames the mapping test file, which was still called PoracleMappingProfileTests.cs while the class inside it had already been renamed to MappingExtensionTests. Nothing referenced the old file name; all 66 tests pass unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241.
AutoMapper was removed in v2.6.0 (#173) in favour of manual mapping extensions, but the docs site never caught up. Four pages still described it as the live mapping layer —
architecture/backend.mdeven carried a working-looking.ForAllMembers(opts => opts.Condition(...))snippet for code that exists nowhere in the repo (grep -rn AutoMapper --include=*.cs --include=*.csprojreturns nothing).The issue points at
architecture/overview.md:94-95; there were five stale spots across four files.Changes
docs/architecture/overview.mdCore.Mappings/line in the solution tree; "AutoMapper for partial updates" section rewritten as "Manual mapping extensions" with a link to Backend Patternsdocs/architecture/backend.mdAlarmMappingExtensions(To*()/ApplyUpdate()) andEntityMappingExtensions(ToModel()/ToEntity()/ApplyTo()), and swaps the fake.ForAllMemberssnippet for the realApplyUpdatenull-skip guardsdocs/development/testing.mdMappingExtensionTestsand what it actually coversdocs/architecture/poracleng-proxy.mdTests/.../Mappings/PoracleMappingProfileTests.csMappingExtensionTests.csThe test file rename is the last bit of AutoMapper residue outside the docs: the file kept its "mapping profile" name while the class inside it had already been renamed to
MappingExtensionTests. Puregit mv— no content change, and nothing (csproj, workflow, doc) referenced the old path.Both surviving mentions of "AutoMapper" in
docs/are the new sentences that state there isn't a dependency, kept so the next reader doesn't reintroduce it.Verification
dotnet test --filter MappingExtensionTests— 66 passed, 0 failed#automapper…anchor links anywhere indocs/,mkdocs.yml, orREADME.md, so no cross-references break with the heading renamesClientApp/src/**and are untouched by this change