Skip to content

Comments

Remember created block#574

Open
Duddino wants to merge 7 commits intoPIVX-Labs:masterfrom
Duddino:remember-saved-block
Open

Remember created block#574
Duddino wants to merge 7 commits intoPIVX-Labs:masterfrom
Duddino:remember-saved-block

Conversation

@Duddino
Copy link
Member

@Duddino Duddino commented Jul 10, 2025

Abstract

Remember shield created block, this mainly affects 2 thigs:

  • When you create a new wallet from a vault, MPW will no longer try to sync from the defaultStartingShieldBlock, but from the createdBlock of the vault (If known, otherwise it will default to defaultStartingShieldBlock)
  • If the sapling shield root check fails, it will skip the processing part of the shield sync, on fast connections this can speed up syncing significantly

Testing

  • Create a new wallet
  • Save on DB
  • Assert that it will sync from the last checkpoint (As of right now it's about 7MB of data)
  • Create a new wallet and assert that it syncs from the last checkpoint
  • Refresh MPW and try syncing a new wallet from that vault, and assert that it syncs from the last checkpoint

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit a1e36d3
🔍 Latest deploy log https://app.netlify.com/projects/cheery-moxie-4f1121/deploys/68e42187896a74000858207e
😎 Deploy Preview https://deploy-preview-574--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 6f1e67d
🔍 Latest deploy log https://app.netlify.com/projects/cheery-moxie-4f1121/deploys/699e104c89733f000800ecc3
😎 Deploy Preview https://deploy-preview-574--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants