Merged
Conversation
JSKitty
approved these changes
Nov 27, 2022
Member
JSKitty
left a comment
JSKitty
left a comment
There was a problem hiding this comment.
tACK, this is a really nice and simplified solution, and I've verified it resolved Labs' issue of Governance Payout blocks being considered owned delegations.
JSKitty
added
Bug
Member
|
🪙 450 PIV bounty fulfilled and sent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #38 merged, we can stop doing the ugly hack of only using the first key for undelegation, plus fixes the issue of MPW thinking some delegations were ours.
The current system will NOT recognize the previous stakes made before #38 was merged, not until DeanSparrow/PIVX-BlockExplorer#13 is merged and the explorers updated