Utilise transactions to keep preserve history#28
Open
phantomeye1931 wants to merge 1 commit intoPKGaspi:mainfrom
Open
Utilise transactions to keep preserve history#28phantomeye1931 wants to merge 1 commit intoPKGaspi:mainfrom
phantomeye1931 wants to merge 1 commit intoPKGaspi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks so much for publishing this script. It has made it really easy to keep my textures organised in 1 file and export them all at once. However, every time I would use it, it would fuck up my entire undo history. This PR is to resolve that.
In all 3 scripts, I utilised a transaction that bundles all edits together, and undoes them at the end. That way, the user's edit history is preserved, and it's restored to the state it was before running the script. This way, you can quickly go back and revert changes made before the export, without having to sit through hundreds of crops.
The diffs show a lot of changed lines, but in reality I only added such wrappers: