-
Notifications
You must be signed in to change notification settings - Fork 10
Executions info panel tweaks #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
canptura
wants to merge
44
commits into
main
Choose a base branch
from
executions_info-panel-tweaks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
8d938ff
fixed word-break
canptura f938080
refactoring
canptura cc28b96
Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into e…
canptura 7d6f1d7
new tab added with placeholder text
canptura 31e3846
more placeholder fields added, refactoring for readability
canptura 7f1772f
styling ideas
canptura a5346ad
timing moved to different tab
canptura f065958
breakpoint causes Modal instead of Drawer
canptura 71cd501
incorporation of some reference layouts and style
canptura 7068e65
tech tags and switch functionality added
canptura c45d6e4
N/A-elements added, grid generalization added, general abstraction
canptura 12fd725
reusable text component added for data display
canptura 2a77911
variable form styling finished, activity styling added
canptura 34e1f7f
removed unwanted and redundant elements, added description text viewe…
canptura a09bc6b
Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into e…
canptura 4d3cb6c
adapted to new stucture
canptura fe67182
Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into e…
canptura 27e896c
bugfix: unknow prop given to DOM element
canptura e261b73
filling some values in the details page
canptura 37992c0
planned delay added
canptura 9fd9631
getProcessVersions server action added, field data added: timing, ini…
canptura 132dfe1
dynamic loading of the textViewer added
canptura e7d6d26
cost display bugfix
canptura da49167
proper image display in overview
canptura 10409aa
removed description styling
canptura eac9feb
Process Manager data added
canptura c467c87
Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into e…
canptura 84e0bc8
refactoring of component names to resemble the tab labels
canptura 1a580c1
removed TODO text contents
canptura c3146e0
date formatting added
canptura 8a1e318
event details panel data added
canptura 863d32e
overview event data added
canptura 801a748
code cleanup
canptura 2b38385
previous step added, some styling
canptura 9c5033d
typo
canptura e7b0a9f
previousStepID, some restyling
canptura 04fc16d
bogfix: wrong instance state on multiple tokens
canptura ffcf389
instance selector set to hide dummy data
canptura 4e36769
cleaning up imports
canptura ba87ab6
hiding and commenting of unused element, display of even name in over…
canptura d54947d
Merge branch 'main' of https://github.com/PROCEED-Labs/proceed into e…
canptura 6e22742
typos and little tweaks
canptura c789a10
actualperformer using correct data
canptura 4ed4a71
loading from log if possible to skip fetching data
canptura File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17
...shboard)/[environmentId]/(automation)/executions/[processId]/element-activity.module.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| .GridContainer { | ||
| display: grid; | ||
| grid-template-columns: repeat(1, 1fr); | ||
| } | ||
|
|
||
| .GridCell { | ||
| padding: 10px 5px; | ||
| border-bottom: 1px solid #ddd; | ||
| } | ||
|
|
||
| .GridCell:last-child { | ||
| border-bottom: none; | ||
| } | ||
|
|
||
| .GridCell:hover { | ||
| background-color: rgba(93, 117, 136, 0.05); | ||
| } |
72 changes: 72 additions & 0 deletions
72
.../app/(dashboard)/[environmentId]/(automation)/executions/[processId]/element-activity.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import { ReactNode } from 'react'; | ||
| import { Col, Row, Tag, Typography } from 'antd'; | ||
| import { ClockCircleFilled } from '@ant-design/icons'; | ||
| import styles from './element-activity.module.scss'; | ||
| import { ElementLike } from 'diagram-js/lib/model/Types'; | ||
| import { ExtendedInstanceInfo } from '@/lib/data/instance'; | ||
|
|
||
| type EntryTextProps = React.ComponentProps<typeof Typography.Text>; | ||
| const TimetableEntryText = (props: EntryTextProps) => ( | ||
| <Typography.Text | ||
| ellipsis={{ tooltip: { ...props } }} | ||
| style={{ | ||
| wordBreak: 'normal', | ||
| }} | ||
| {...props} | ||
| /> | ||
| ); | ||
|
|
||
| const ClockSymbol = () => ( | ||
| <ClockCircleFilled style={{ fontSize: '1.1rem', verticalAlign: 'middle' }} /> | ||
| ); | ||
|
|
||
| export function ElementActivity({ | ||
| processId, | ||
| element, | ||
| instance, | ||
| }: { | ||
| processId: string; | ||
| element?: ElementLike; | ||
| instance?: ExtendedInstanceInfo; | ||
| }) { | ||
| const activityEntries: ReactNode[][] = []; | ||
|
|
||
| const activityLog: [string, 'INFO' | 'WARN', string][] = [ | ||
| ['09:14:02', 'INFO', 'Process started by m.chen'], | ||
| ['09:15:02', 'INFO', "ZStep 'Receive Application' started"], | ||
| ['09:16:13', 'INFO', "Step 'Receive Application' completed"], | ||
| ['09:18:23', 'INFO', "Gateway 'Application complete?' yes"], | ||
| ['09:23:13', 'INFO', "Step 'Credit Check' started"], | ||
| ['09:19:35', 'WARN', 'Credit Bureau response delayed (retry 1/3)'], | ||
| ['09:25:54', 'INFO', "Step 'Credit Check' completed"], | ||
| ['09:35:23', 'INFO', "Step 'Manager Approval' started"], | ||
| ]; | ||
|
|
||
| const tagStatus: Record<'INFO' | 'WARN', string> = { | ||
| INFO: 'processing', | ||
| WARN: 'warning', | ||
| }; | ||
|
|
||
| return ( | ||
| <div | ||
| className={styles.GridContainer} | ||
| style={{ border: 'solid 1px #ddd', borderRadius: 12, marginBlock: 15 }} | ||
| > | ||
| {activityLog.map((row, idx_row) => ( | ||
| <Row key={'activity' + idx_row} className={styles.GridCell}> | ||
| <Col flex="70px" style={{ textAlign: 'center' }}> | ||
| {row[0]} | ||
| </Col> | ||
|
|
||
| <Col flex="70px" style={{ textAlign: 'center' }}> | ||
| <Tag color={tagStatus[row[1]]}>{row[1]}</Tag> | ||
| </Col> | ||
|
|
||
| <Col flex="auto" style={{ padding: '0 10px' }}> | ||
| {row[2]} | ||
| </Col> | ||
| </Row> | ||
| ))} | ||
| </div> | ||
| ); | ||
| } | ||
12 changes: 12 additions & 0 deletions
12
...ashboard)/[environmentId]/(automation)/executions/[processId]/element-details.module.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| .ElementText { | ||
| word-break: normal; | ||
| } | ||
|
|
||
| .ElementKeyText { | ||
| color: gray; | ||
| font-size: 0.8em; | ||
| } | ||
|
|
||
| .ElementValueText { | ||
| font-size: 0.9em; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think as of now there is no indication in the logs of an instance that links a log output to a specific activity so this might be a bit harder to do with actual instance data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think activity is just supposed to be the frontend name for the log display