Repository navigation
Invoke the DEV retention SSH transport and test the workflow runner - #831
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retention workflow imported the verified SSH module, whose CLI entry point is guarded by require.main, so importing it alone did not execute the read-only plan. Invoke its exported deploy function explicitly and propagate transport errors to the job result.
Four Node tests execute the actual workflow JavaScript with a stub transport: a real invocation with credentials kept outside the remote script, the exact apply digest, rejected mode/shell input, and failing the job on remote failure. Run these tests in the retention workflow before SSH. All four pass locally; YAML/JavaScript syntax and diff checks pass. No cleanup was performed by the earlier no-op job; image retention rules and application code are unchanged.