-
Notifications
You must be signed in to change notification settings - Fork 8
Update to Oceananigans v0.106 and migrate to NumericalEarth #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glwagner
wants to merge
85
commits into
main
Choose a base branch
from
glw/up
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
f2fde93
Update to Oceananigans v0.105 and migrate ClimaOcean to NumericalEarth
glwagner 6b1217b
Restore first_time_step\! and keep FixedIterations
glwagner fbc5744
Replace exponential_z_faces with ExponentialDiscretization
glwagner bb96e8a
Switch ocean climate simulation to LatitudeLongitudeGrid
glwagner 2274d2d
Use EN4 instead of ECCO for ocean climate simulation
glwagner da53b26
Make grid a positional arg to HydrostaticFreeSurfaceModel (Oceananiga…
glwagner 2589f0e
Point Oceananigans to branch with view fix for cpu_face_constructor_r
glwagner 25395a2
Trigger CI with updated Oceananigans fixes (view + OffsetArray)
glwagner 6b2c0bc
Fix filtered_state field names for SplitExplicitFreeSurface in correc…
glwagner 9bd3d6a
Reduce sharded test grid size to avoid OOM on CI
glwagner 4d4789a
Fix NaN in tendencies by forcing euler=true on first time step
glwagner a44d849
Call Oceananigans.initialize! in first_time_step!
glwagner 1201f0e
Don't throw on initial state comparison (Gⁿ is uninitialized)
glwagner 1a82ea8
Don't throw on Gⁿ comparison after initial update_state\!
glwagner 8c7d587
Point Oceananigans to glw/reactant-correctness and add maybe_initiali…
glwagner ae2645e
Revert maybe_initialize_state\! no-op (moved to Oceananigans)
glwagner 461d36b
Always compare tendencies on interior only
glwagner cebff2f
throw error on compare states
glwagner 3696760
use lat-lon grid for data-free
glwagner 008ba82
Update precompile imports for Oceananigans v0.105 API
glwagner 67cf652
Merge branch 'main' into glw/up
glwagner f2bd340
define special first_time_step for QAB2 timestepper
glwagner f27f68d
Merge branch 'glw/up' of https://github.com/PRONTOLab/GB-25 into glw/up
glwagner 70bf424
update to latest tagged Oceananigans
glwagner 5d0228f
cleanup
glwagner 2aaf23b
use 3 for Ninner rather than ConcreteRNumber
glwagner 3598b01
Update simulations/baroclinic_instability_simulation_run.jl
glwagner 57976e9
ensure we use QAB2 timestepper
glwagner e5fa36f
force main for both Reactant and ReactantCore
glwagner 5bb873a
Merge branch 'glw/up' of https://github.com/PRONTOLab/GB-25 into glw/up
glwagner b9d35ff
quality Periodic (plus other topologies)
glwagner 07dd736
try workaround for number promotion bug
glwagner 4f57792
that didnt work
glwagner 7ec4d14
use new Oceananigans branch
glwagner 5a24b9d
trigger CI
glwagner 3ff4809
Point to new NumericalEarth branch
glwagner ca53d6b
zero tendencies before initialize! is called in correctness
glwagner 85e9271
Update simulations/ocean_climate_simulation.jl
glwagner 4e8b2c3
Update Project.toml
glwagner 0e353d4
Update Project.toml
glwagner ba88003
Update Project.toml
glwagner 8ff9128
update compat
glwagner 1b1547a
Update sharding/sharded_baroclinic_instability_simulation_run.jl
glwagner 3d53573
Add CUDA and pray
dkytezab 122120c
add back zero_tendencies
glwagner 2d0b1ec
Fix NaN in correctness tests from zero-thickness vertical grid cells
glwagner fe9f0e5
Reduce Ninner from 3 to 2 to avoid OOM during loop! compilation
glwagner 383a84f
Trigger CI to pick up Oceananigans tick! fix
glwagner c3651a7
Pin Oceananigans to specific commit with tick! fix
glwagner baa55a0
Use optimization_barrier to break clock field alias in tick!
glwagner 06104b0
Revert throw_error=false to throw_error in correctness tests
glwagner da1e0f1
try Ninner=1 for compile
glwagner 5337a37
cleanup
glwagner 744e6dd
Merge branch 'main' into glw/up
glwagner 6af3510
add eager registry preference
glwagner 8485e9a
require _jll 0.358
glwagner 7a9f37d
fix
glwagner 4bbbb40
point to oceananigans 106.1
glwagner 221c059
Update Project.toml
glwagner 116733e
try Reactant fixup
Pangoraw b236589
try TenUnrolledIterations
glwagner a21a7bc
Only check for the op
Pangoraw 8e2ebdd
Update ocean_climate_simulation_run.jl
glwagner 0d54917
newest reactant
Pangoraw 3a89118
Update sharded_baroclinic_instability_simulation_compile.jl
Pangoraw cafeb0c
Actually fix debug compile
Pangoraw 1e09ee4
take2
Pangoraw 0ee7d91
Update sharded_baroclinic_instability_simulation_compile.jl
Pangoraw 43ba004
Update baroclinic_instability_simulation_compile.jl
Pangoraw b8c4572
Update ocean_climate_simulation_compile.jl
Pangoraw 4a737e0
Pass ctx to code_hlo calls in compile scripts
Pangoraw f08a3f3
Pass args as tuple to Reactant.Compiler.code_hlo
Pangoraw c51a466
cancel
Pangoraw 7ed879f
Try Reactant workaround
Pangoraw 02b90f0
agro
Pangoraw fa91d4f
no aggro
Pangoraw 0d57984
here we go again
Pangoraw 50371f5
Update src/data_free_ocean_climate_model.jl
glwagner f511bc5
Merge branch 'main' into glw/up
glwagner ae645f8
Update correctness_baroclinic_instability_simulation_run.jl
glwagner 6e2c1f2
Update correctness_sharded_baroclinic_instability_simulation_run.jl
glwagner da9b7e6
Merge branch 'main' into glw/up
glwagner 7bd9894
Merge branch 'main' into glw/up
dkytezab 0590584
Use ConcreteRNumber for baroclinic inner loop
glwagner ab53225
Pin ClimaSeaIce for NumericalEarth CI
glwagner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glwagner and @giordano please re-enable precompilation [and test this]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remind myself how we triggered these in
Project.toml