Add moist baroclinic wave atmosphere example#275
Draft
dkytezab wants to merge 175 commits into
Draft
Conversation
glwagner
reviewed
Mar 31, 2026
dkytezab
changed the title
Collaborator
Author
Collaborator
|
I believe that'll be fixed by github.com/CliMA/ClimaSeaIce.jl/pull/127. Alternatively, temporarily pin ClimaSeaIce to v0.4.5 |
…/GB-25 into dkz/atmosphere-example
to avoid microphys issues
giordano
reviewed
Apr 12, 2026
… path Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…m NN kernel The custom _nn_atmos_field_copy! kernel mapped N+1 source faces to N+1 target faces for Face+Bounded fields, using a different ratio than InterpolateArray's N-to-N mapping. Replace with interpolate! which handles Face/Center locations and coordinate mapping correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
strip all debuginfo
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…n conflicts Keep atmosphere_coarsened_1536x768x64.jld2 IC path. Use upstream's cleaner InterpolateArray(src_reactant, ...) call. Keep defensive microphysics guards. Made-with: Cursor
The 1/8° source IC can contain small negative moisture values (min ~-1e-4) from bounds-preserving WENO during the source run. When interpolated to a higher-resolution target grid and hit by the first microphysics step, those negatives reliably produce NaN cells on particular tiles, stopping the spinup at iteration 2. Clamping ρqᵛ to ≥ 0 immediately after interpolation removes that root cause. Applied in both the Reactant-based and vanilla IC loaders. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…/GB-25 into dkz/atmosphere-example Made-with: Cursor # Conflicts: # sharding/sharded_atmosphere_simulation_run.jl
Add commented out comms opts off compile_options
These dont seem to be necessary at least for sharding/sharded_atmosphere_simulation_run.jl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge. Some hacking of environments needs to be done while we wait for upstream prs