Skip to content

Fix incorrect kv_head_idx computation breaks GQA/MHA head-to-KV-head mapping #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oyeong011 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix incorrect kv_head_idx computation breaks GQA/MHA head-to-KV-head mapping #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/operations/Attention.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ void Attention::initialize_instructions(Tile* tile, int head_idx, int num_heads)
addr_type value_addr = get_operand_addr(_INPUT_OPERAND + 2);
addr_type ouput_addr = get_operand_addr(_OUTPUT_OPERAND);
assert(num_heads <= _nkvh);
int kv_head_idx = head_idx / _nkvh;
int kv_head_idx = head_idx / num_heads;
addr_type sram_k_ofs = sram_key_base + kv_head_idx * (_dk * seq_len) * _config.precision;
addr_type sram_v_ofs = sram_value_base + kv_head_idx * (_dk * seq_len) * _config.precision;
std::set<addr_type> dram_kv_addrs; // = _key[req_idx]->get_all_addrs();
Expand Down Expand Up @@ -356,7 +356,7 @@ void Attention::initialize_instructions(Tile* tile, Mapping mapping, int head_id
addr_type ouput_addr = get_operand_addr(_OUTPUT_OPERAND);
addr_type logits_addr = get_operand_addr(_OUTPUT_OPERAND) + _dmodel * _q_len * _config.precision; // logits addr for scale
assert(num_heads <= _nkvh);
int kv_head_idx = head_idx / _nkvh;
int kv_head_idx = head_idx / num_heads;
addr_type sram_k_ofs = sram_key_base + kv_head_idx * (_dk * seq_len) * _config.precision;
addr_type sram_v_ofs = sram_value_base + kv_head_idx * (_dk * seq_len) * _config.precision;
std::set<addr_type> dram_kv_addrs; // = _key[req_idx]->get_all_addrs();
Expand Down