Skip to content

Metrics bot uses wrong branch #81

Closed

Description

@bird-dancer

The metrics bot runs on: [pull_request_target] meaning it operates on the target ie. master branch not on the branch requesting to be pulled.
For example: In this pr: #80 there are two commits. One that doesn't influence metrics at all and one that yields an error rate of 100% but the bot comments the same error rate of 15% on both.
So the metrics should either be done on push, on pull_request with some setup not requiring access to secrets, or remain on pull_request_target but explicitly checkout the pr branch after human approval.

Activity

  1. cwerling commented on Jan 30, 2026

    @cwerling
    Member

    Thanks for spotting this! I chose to allow all pull_requsts to access the fixtures repo through this.

  2. added a commit that references this issue on Mar 9, 2026
    77eb027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions