Open
Conversation
…DetachedTabController.java
used for scaling detached window
new file: src/main/resources/Views/DetachedTabView.fxml
new View with an empty anchorPane
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Controller/MainController.java
added methods responsible for detaching tab (detaching and detachTab) and calling detaching in initialize()
and methods responsible for changing mode to light or dark(applyStyleToNode, findAndStyleTiles, applyTileStyle, applyGaugeStyle) and using them in invalidated()
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Controller/SettingsController.java
added method onToggleLightMode that uses Configuration
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Main.java
not adding DetachedTabView to loaders
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Model/Configuration/Configuration.java
adding field lightMode and method setLightMode to use observable in MainController
modified: src/main/resources/Views/SettingsView.fxml
added toggle button to switch between modes(light dark)
modified: src/main/resources/Views/constants.css
new file: src/main/resources/Views/constantsLight.css
to switch between css when changing mode(light dark)
…DetachedTabController.java
used for scaling detached window
new file: src/main/resources/Views/DetachedTabView.fxml
new View with an empty anchorPane
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Controller/MainController.java
added methods responsible for detaching tab (detaching and detachTab) and calling detaching in initialize()
and methods responsible for changing mode to light or dark(applyStyleToNode, findAndStyleTiles, applyTileStyle, applyGaugeStyle) and using them in invalidated()
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Controller/SettingsController.java
added method onToggleLightMode that uses Configuration
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Main.java
not adding DetachedTabView to loaders
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Model/Configuration/Configuration.java
adding field lightMode and method setLightMode to use observable in MainController
modified: src/main/resources/Views/SettingsView.fxml
added toggle button to switch between modes(light dark)
modified: src/main/resources/Views/constants.css
new file: src/main/resources/Views/constantsLight.css
to switch between css when changing mode(light dark)
…wanie taba z glownego okna, usuniecie linijki z readme(z path javafx), ustawienie glownego okna na caly ekran
…/DetachedTabController.java
few changes, logic the same
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Controller/MainController.java
added methods for detaching tabs - setupDetachedWindowsProvider, configureTabContextMenu,detachTabToNewWindow , and changed the warning in findAndStyleTiles
created: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Provider/DetachedWindowsProvider.java
added a class used for managing all active tab panes, has a method for transfering tabs
modified: src/main/resources/Views/DetachedTabView.fxml
added TabPane
modified: src/main/resources/Views/constants.css
changes for ContextMenu
modified: src/main/resources/Views/constantsLight.css
changes for ContextMenu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now tabs can be detached between windows
modified: src/main/java/pl/edu/pwr/pwrinspace/poliwrocket/Controller/DetachedTabController.java
few changes, logic the same
added methods for detaching tabs - setupDetachedWindowsProvider, configureTabContextMenu,detachTabToNewWindow , and changed the warning in findAndStyleTiles
added a class used for managing all active tab panes, has a method for transfering tabs
added TabPane
changes for ContextMenu
changes for ContextMenu