refactor: simplify scrollbar styles across components#288
Merged
Conversation
Contributor
There was a problem hiding this comment.
ℹ️ No critical issues — minor suggestions inline.
Reviewed changes — adds a global custom-scrollbar rule in index.css and removes duplicated per-component WebKit scrollbar classes from five components, plus defines the previously missing .no-scrollbar utility.
- Global scrollbar styles in
apps/web/src/index.cssapplyscrollbar-width: thinand WebKit thumb/track styling via the universal selector. - Removed local scrollbar classes in the chat thread, doc editor, task detail modal, add-workflow-node modal, and add-task-link modal now that the global rule covers them;
scrollbar-gutter:stableis preserved. - Defined
.no-scrollbarto match its existing use inapps/web/src/components/ui/sidebar.tsx.
Kimi K2 (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
index.css, applied via the universal selector so every scrollable element in the app — tables, dropdowns, kanban board, modals, chat panes, sidebar — gets it automatically instead of relying on the browser default..no-scrollbarutility, which was referenced by the sidebar nav rail but never actually defined, so it was silently falling back to the plain scrollbar.scrollbar-gutter:stableis kept where it was preventing layout shift.Test plan
bun run linttsc -b