Skip to content

refactor: simplify scrollbar styles across components#288

Merged
pikann merged 1 commit into
masterfrom
refactor/simplify-scrollbar-styles
Jul 17, 2026
Merged

refactor: simplify scrollbar styles across components#288
pikann merged 1 commit into
masterfrom
refactor/simplify-scrollbar-styles

Conversation

@pikann

@pikann pikann commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a global, theme-aware custom scrollbar (thin, transparent track, rounded thumb, darkens on hover) in index.css, applied via the universal selector so every scrollable element in the app — tables, dropdowns, kanban board, modals, chat panes, sidebar — gets it automatically instead of relying on the browser default.
  • Define the .no-scrollbar utility, which was referenced by the sidebar nav rail but never actually defined, so it was silently falling back to the plain scrollbar.
  • Remove the duplicated per-component WebKit-only scrollbar classes that a few components had hand-rolled (chat thread, docs editor, task detail modal, add-task-link modal, add-workflow-node modal), now that the global rule covers them. scrollbar-gutter:stable is kept where it was preventing layout shift.

Test plan

  • bun run lint
  • tsc -b
  • Visual check in browser across a table, a dropdown, and the chat thread (light + dark mode)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — minor suggestions inline.

Reviewed changes — adds a global custom-scrollbar rule in index.css and removes duplicated per-component WebKit scrollbar classes from five components, plus defines the previously missing .no-scrollbar utility.

  • Global scrollbar styles in apps/web/src/index.css apply scrollbar-width: thin and WebKit thumb/track styling via the universal selector.
  • Removed local scrollbar classes in the chat thread, doc editor, task detail modal, add-workflow-node modal, and add-task-link modal now that the global rule covers them; scrollbar-gutter:stable is preserved.
  • Defined .no-scrollbar to match its existing use in apps/web/src/components/ui/sidebar.tsx.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

@pikann
pikann merged commit 4c6c913 into master Jul 17, 2026
1 check passed
@pikann
pikann deleted the refactor/simplify-scrollbar-styles branch July 17, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant