This repository was archived by the owner on Jan 11, 2020. It is now read-only.
Support class_name specified with a class, not a string#4
Open
steverice wants to merge 1 commit into
Open
Conversation
steverice
force-pushed
the
support-real-classes
branch
from
bb6b2cb to
d6c6054
Compare
It's completely valid in ActiveRecord to specify the `class_name` as an actual class reference, so `ManyToMany` should support it as well. http://guides.rubyonrails.org/association_basics.html#options-for-belongs-to-class-name
steverice
force-pushed
the
support-real-classes
branch
from
d6c6054 to
2409623
Compare
theckman
reviewed
Nov 2, 2016
| has_many :simple_belongs_tos | ||
| has_many :belongs_to_throughs, through: :simple_belongs_tos | ||
| has_many :class_nameds, class_name: 'ManyToManyTest::SomeClassName' | ||
| has_many :class_nameds_by_class, class_name: ManyToManyTest::SomeClassNamedByClass |
There was a problem hiding this comment.
I think this needs to be changed to class_named_by_classs? Pretend you're a snake!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's completely valid in ActiveRecord to specify the
class_nameas an actual class reference, soManyToManyshould support it as well.http://guides.rubyonrails.org/association_basics.html#options-for-belongs-to-class-name