Repository navigation
Conversation
在已加载的 World 上装了新版本，原先它会进「待生效」，可它其实仍在跑旧版本：状态灯、开关和左栏入口都还在。 现在它留在「我的 World」原位，名字后面在更新箭头的位置换成同色的旋转图标：悬停显示 「重启进程后生效 vX → vY」，点击弹出现有的重启进程确认。「待生效」只放进程启动后新装、还没加载的包。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // package's page, where the update is. | ||
| if (pack && market && updatePending(item)) { | ||
| const owner = market; | ||
| heading.append(iconButton('refresh', S.updatePendingRestart(pack.version ?? '?', pack.installedVersion ?? '?'), 'world-name-update world-name-pending', () => void owner.restart())); |
There was a problem hiding this comment.
docs/webui.md 把 src/web/client/features/worlds/index.ts 列为 owner，并且写着「名称旁保留可用更新入口」。这个 hunk 在同一位置改成了进程重启图标，页面没有跟着改。
AGENTS.md §8：「The commit that changes the owner changes the page.」
请把 docs/webui.md 改到与现行为一致，或把偏离这条规则的理由写进 PR 描述。
— Cortico PR Gate via Cursor Cloud Agent
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #378
中文
在已加载的 World 上装了新版本后，
/api/extensions把它报成pending-restart，WebUI 就把它放进「待生效」，标「已安装，待重启」。可进程在重启前跑的一直是启动时加载的旧版本，所以状态灯、开关和左栏入口都还在，和「待生效」自相矛盾。只重启这一个 World 也换不到新版本：/api/worlds/restart重新挂载的是内存里已有的实例。这个 PR 只改「我的 World」页：
state === 'pending-restart' && loaded）的 World 留在原位，状态、状态灯、开关和左栏入口照旧。实现：
worlds/library.ts加updatePending(item)，needsRestart不再包括它；ExtensionController加restart()，复用现有的重启流程；新文案 11 种语言都有。重启前，WebUI 发出的面板产物可能已经是磁盘上的新版本，这是 #378 的问题，这个 PR 不改。
测试：更新后的 World 留在原位，图标写明版本并提供重启；只有新装的包进「待生效」。
pnpm test、pnpm run typecheck、pnpm typecheck:web通过。本机上有 Cortico 进程在跑，所以没有运行pnpm build:web。Coopanion 设置页的同一改动：Pal-AI-Lab/Coopanion#629。
🤖 Generated with Claude Code