-
Notifications
You must be signed in to change notification settings - Fork 1
[feature] adding mypy for static typing #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmitrii-palisaderesearch
merged 13 commits into
main
from
koldyba/feature/GLT-1411-enhance-ci
Aug 18, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
30dcbd2
adding mypy for static typing
sergey-koldyba b52f9ae
fix comments
sergey-koldyba f462a8c
remove separate typecheck workflow
sergey-koldyba fe73acd
move uv to nix, update readme
sergey-koldyba af27cfd
update flake.nix
sergey-koldyba f39be7a
target mypy to venv python executable
sergey-koldyba edcc54f
remove python version pinning for mypy config
sergey-koldyba caa75cc
moving dev dependencies to uv to avoid library issues
sergey-koldyba 30ac5e9
switch to ty
sergey-koldyba d992a6d
update ty
sergey-koldyba ae4b538
README: mypy=>ty
dmitrii-palisaderesearch 68abea2
Merge branch 'main' into koldyba/feature/GLT-1411-enhance-ci
dmitrii-palisaderesearch 6ad0999
settings.json: Drop pyright settings since we disable the language se…
dmitrii-palisaderesearch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| { | ||
| "recommendations": [ | ||
| "myriad-dreamin.tinymist", | ||
| "ms-python.black-formatter", | ||
| "charliermarsh.ruff", | ||
| "mkhl.direnv", | ||
| "editorconfig.editorconfig", | ||
| "timonwong.shellcheck", | ||
| "melak47.ninja-syntax", | ||
| "semgrep.semgrep" | ||
| "semgrep.semgrep", | ||
| "astral-sh.ty" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,16 @@ | ||
| { | ||
| "python.analysis.typeCheckingMode": "basic", | ||
| "python.analysis.autoImportCompletions": true, | ||
| "[python]": { | ||
| "editor.formatOnSave": true, | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll": "explicit", | ||
| "source.organizeImports": "explicit" | ||
| }, | ||
| "editor.defaultFormatter": "charliermarsh.ruff" | ||
| }, | ||
| // disable python language server since we're using astral-sh.ty | ||
| "python.languageServer": "None", | ||
| "notebook.formatOnSave.enabled": true, | ||
| "notebook.codeActionsOnSave": { | ||
| "notebook.source.fixAll": "explicit", | ||
| "notebook.source.organizeImports": "explicit" | ||
| }, | ||
| "tinymist.formatterMode": "typstyle", | ||
| "tinymist.systemFonts": false | ||
| "tinymist.systemFonts": false, | ||
| // Format Python files on save using ruff | ||
| "[python]": { | ||
| "editor.formatOnSave": true, | ||
| "editor.defaultFormatter": "charliermarsh.ruff" | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,6 @@ | |
| ninja | ||
| # Python | ||
| uv | ||
| ruff | ||
| # Typesetting | ||
| typst | ||
| texlive.combined.scheme-medium | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.