Add env hints#40
Conversation
Summary of ChangesHello @alexb-palisaderesearch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the developer experience by providing clearer guidance for environment variable setup and correcting minor documentation formatting. It centralizes essential configuration information and streamlines the initial project setup process for new contributors, making it easier to get started with the project. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the developer experience by adding helpful hints and URLs to the .env.example file for obtaining necessary API keys. It also updates the README.md with clearer setup instructions and fixes some markdown formatting. My review includes suggestions to make required environment variables more explicit in .env.example to prevent setup issues for new developers, based on the project's stated goals in the README.
sergey-koldyba
left a comment
There was a problem hiding this comment.
GLTM. However, more structured .env.example will be appreciated
There was a problem hiding this comment.
Don't want to be a wet blanket, but can we have it more structured?
My usual recommendations are:
- keep fields that are required uncommented
- keep value snake_case for easier select-and-replace
- have more meaningful comments and a bit better structure
My recommendation would look like similar to this:
# ---LOGFIRE---
#Environment identifier
LOGFIRE_ENVIRONMENT=hostname_username
# Logire tokens
# Get API Keys here: https://logfire-us.pydantic.dev/palisaderesearch/-/projects -> project settings -> API keys
LOGFIRE_WRITE_TOKEN=your_logfire_write_api_token
# LOGFIRE_READ_TOKEN=your_logfire_read_api_token
#Logfire logging settings
LOGFIRE_CONSOLE_VERBOSE=True
LOGFIRE_CONSOLE_MIN_LOG_LEVEL=debug
# ---LANGFUSE---
# Langfuse host URL
LANGFUSE_HOST=https://us.cloud.langfuse.com
# Langfuse tokens
# Get API Keys here: https://us.cloud.langfuse.com/ -> project settings -> API keys
LANGFUSE_SECRET_KEY=your_langfuse_secret_key
LANGFUSE_PUBLIC_KEY=your_langfuse_public_key
# Uncomment to disable Langfuse tracking entirely
# LANGFUSE_SKIP=1
# ---AI TOKENS---
# Use at least one AI API Key
# Get API Keys here: https://platform.openai.com/settings/organization/api-keys
# OPENAI_API_KEY=you_openai_api_token
# Get API Keys here: https://platform.claude.com/settings/keys
# ANTHROPIC_API_KEY=your_anthropic_api_key
# Get API Keys here: https://aistudio.google.com/app/apikey
# GEMINI_API_KEY=your_gemini_api_key
# Get API Keys here: https://openrouter.ai/settings/keys
# OPENROUTER_API_KEY=your_openrouter_api_key
No description provided.