Refactor: use session.isResponding to track model state#3
Open
davidiaz1251 wants to merge 1 commit intoPallavAg:mainfrom
Open
Refactor: use session.isResponding to track model state#3davidiaz1251 wants to merge 1 commit intoPallavAg:mainfrom
davidiaz1251 wants to merge 1 commit intoPallavAg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replaces the local
@State isRespondingwith a computed property that referencessession?.isResponding. This improves consistency by ensuring the UI reflects the actual state of the model session and avoids maintaining redundant state.Why it matters
Avoids potential desynchronization between the UI state and the model state during streaming or generation.
Let me know if any adjustments are needed — happy to update.