Repository navigation
feat(api): account-wide naming instructions in userSettings - #9388
Draft
aaronrosenthal wants to merge 2 commits into
Draft
aaronrosenthal wants to merge 2 commits into
aaronrosenthal wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Second of three PRs for #9197. Depends on #9387. This is a fork PR, so it can't be stacked on that branch and also contains its commit. Review only the top commit,
feat(api): account-wide naming instructions in userSettings.userSettingsnow carries the person's account-wide naming instructions:getreturns a newnamingInstructions: string | nullfield. Accounts without a row getnull.updatetakes a new optionalnamingInstructions: string | null(max 2000 characters, the same limit as the per-project field on the host). The value is trimmed, and blank saves asnull.Compatibility (
trpc-compat): both changes are additive. Every existing input stays valid, nothing is tightened, and the output only gains a field. Released desktop and mobile builds callgetandupdate({ experimentalChat })and are unaffected. Theupdatehandler builds thesetobject explicitly, so a call that omits a field never writes it.How I tested it
user-settings.test.ts:namingInstructions: nullupdatestores only the fields it was givennulluser_settings.naming_instructionsfor the signed-in user, checked in the DB.Checklist
type(scope): subject)bun run lintandbun run typecheckpass (CI fails on lint warnings too)Summary by cubic
Adds account-wide naming instructions to
userSettings, the second of three PRs for #9197.getnow returnsnamingInstructions: string | null(null when the account has no row), andupdateaccepts an optionalnamingInstructionsfield up to 2000 characters; values are trimmed and blank strings are saved asnull. Both changes are additive, so existing clients that passexperimentalChatonly are unaffected. Adds anaming_instructionscolumn touser_settingsin migration0190_user_settings_naming_instructions.Written for commit d3e34ed. Summary will update on new commits.