[Claude] add subscription tracking

[ParadoxZero]

No description provided.

[ParadoxZero]

Overall: Request Changes

This PR adds a well-structured subscription tracking feature end-to-end (backend + frontend). The architecture is clean, the demo/local mode is properly implemented, and the UX is thoughtful. However, there are several issues that should be addressed before merging:

Major Issues (blockers):

1. [FromBody] attribute missing on AddRecurring (line 111) and UpdateRecurring (line 117) in budget_controller.cs — may cause null binding in some ASP.NET Core configurations.
2. 2. throw new Exception("Recurring item not found") in db_service.cs line 236 returns a 500 instead of a 404 for a valid "not found" case.
3. 3. RemoveAll in DeleteRecurringAsync silently succeeds even for non-existent IDs, always returning 200 OK — this masks frontend bugs.
      Minor suggestions (non-blocking):
4. AddRecurring/UpdateRecurring/DeleteRecurring in user_data_service.cs should use the Async suffix for naming consistency.
5. 5. frequencey_unit typo — good time to fix this across the datamodel since the feature is new.
6. 6. default branch in totalMonthly incorrectly adds full amount for quarterly/halfYearly frequencies.
7. 7. form missing from useEffect dependency array in subscription_modal.tsx.
      Positive notes:

• Clean three-layer separation maintained throughout.
• • LastUpdated timestamps correctly set in both add and update paths.
• • • Local (demo mode) implementation included for all new operations.
• • • • Loading state properly threaded through the modal.

[ParadoxZero]

[Major Issue] throw new Exception returns 500 instead of 404

Throwing a generic Exception when a recurring item isn't found will bubble up as a 500 Internal Server Error to the client. This should be a 404. Consider one of two approaches:

1. Return null here and check for it in the controller, returning NotFound():
3. if (index == -1) return null;
5. Or throw a more specific exception type (e.g., KeyNotFoundException) and add global exception-handling middleware that maps it to a 404 response.
   The current behavior gives callers a confusing 500 error for a perfectly valid "not found" scenario.

[ParadoxZero]

[Major Issue] Silent no-op on delete — always returns 200 OK

RemoveAll returns the number of items removed but the return value is discarded. If the caller sends a non-existent recurring_id, the method silently succeeds, removes nothing, and still returns 200 OK with the unchanged budget. This masks bugs in the frontend.

Suggest checking the removed count and returning a 404 if nothing was removed:

int removed = budget.recurringList.RemoveAll(r => r.Id == recurring_id);
if (removed == 0) return null; // caller maps to NotFound()

[ParadoxZero]

[Minor] Missing Async suffix — inconsistent naming convention

The new methods AddRecurring, UpdateRecurring, and DeleteRecurring are async but omit the Async suffix. Every other async method in this file (and db_service.cs) uses the Async suffix convention (e.g., DeleteExpenseAsync, RolloverBudget is the one exception).

For consistency with the rest of the codebase, these should be renamed to AddRecurringAsync, UpdateRecurringAsync, and DeleteRecurringAsync.

[ParadoxZero]

[Major Issue] Missing [FromBody] attribute on POST/PUT endpoints

The recurring parameter is a complex object sent as JSON in the request body, but there is no [FromBody] attribute. Without it, ASP.NET Core may fail to bind the parameter from the request body in some configurations, resulting in a null recurring object silently passed to the service.

Same issue applies to line 117 (UpdateRecurring).

Fix:

public async Task<IActionResult> AddRecurring(string budget_id, [FromBody] Recurring recurring)

Also consider adding [FromRoute] on budget_id for explicitness, matching the intent.

[ParadoxZero]

[Minor] frequencey_unit — pre-existing typo, good time to fix

The field name frequencey_unit (misspelling of "frequency") is a pre-existing issue in the datamodel, but this PR is the first time it's used extensively in new UI code. Since the feature is brand new and no existing data depends on this field name yet, this is a low-cost opportunity to fix the spelling to frequency_unit across the datamodel, backend model, and all frontend references.

If left as-is, the typo will propagate further with each PR that touches this feature.

[ParadoxZero]

[Minor] form missing from useEffect dependency array

form (from Form.useForm()) is used inside this effect but is not listed as a dependency. While form is a stable ref in Ant Design so this won't cause a runtime bug, it will trigger the react-hooks/exhaustive-deps ESLint rule if that's enabled.

Consider adding form to the dependency array:

}, [isOpen, initialValues, form]);

[ParadoxZero]

[Minor] default branch incorrectly counts quarterly/halfYearly as full monthly amounts

The default case here catches RecurringType.quarterly and RecurringType.halfYearly and adds the full amount as if it were a monthly expense. The correct multipliers are:

• Quarterly → r.amount / 3
• • Half-yearly → r.amount / 6
    While these frequency types are currently unsupported in the UI (not shown in frequencyOptions), they exist in the data model and can appear in existing data. If nothing else, add a comment explaining why default is intentionally incorrect:

// quarterly and halfYearly are unsupported; excluded from monthly estimate
default: return sum;