Conversation
ammedd
reviewed
Feb 19, 2026
ammedd
reviewed
Feb 19, 2026
Collaborator
ammedd
left a comment
ammedd
left a comment
There was a problem hiding this comment.
Code looks resonable, but without my laptop I can't test it. If @erikvansebille has time that would be better
Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
Collaborator
Author
|
Thanks both, changes now implemented 👍 |
erikvansebille
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a warning stage if the
resultsdir already exists in the expedition dir. If it does it will give the option to continue and overwrite the previous results, and also provides messaging thatresultsshould be moved/renamed if the user doesn't want to overwrite it.Closes #261