Skip to content

Grading/Feedback PR [DO NOT MERGE]#8

Open
martypdx wants to merge 2 commits into
Park-Place:masterfrom
martypdx:master
Open

Grading/Feedback PR [DO NOT MERGE]#8
martypdx wants to merge 2 commits into
Park-Place:masterfrom
martypdx:master

Conversation

@martypdx
Copy link
Copy Markdown

  • Nice work putting together a README! Would be good to include any developer-specific instructions for working with the project
  • Remove unused files (i.e. PrivateRoute, reviewAPI)
  • Don't use connect when there is no store or dispatch being mapped (see Search component)
  • Watch out for double subscribes on firebase listeners. You need to unsubscribe on major action like logout and subsequent login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant