Refactor load_state_dict method to accept state_dict directly#7
Open
JackMcKechnie wants to merge 1 commit into
Open
Refactor load_state_dict method to accept state_dict directly#7JackMcKechnie wants to merge 1 commit into
JackMcKechnie wants to merge 1 commit into
Conversation
Refactor load_state_dict method to accept state_dict directly and handle string input.
Contributor
Author
|
This seems to work, helping with validation |
Parry-Parry
requested changes
Nov 19, 2025
| return self.model.load_state_dict( | ||
| self.architecture_class.from_pretrained(model_dir).state_dict() | ||
| ) | ||
| def load_state_dict(self, state_dict, strict=False, **kwargs): |
Owner
There was a problem hiding this comment.
The naming here gets a bit weird,
| self.architecture_class.from_pretrained(model_dir).state_dict() | ||
| ) | ||
| def load_state_dict(self, state_dict, strict=False, **kwargs): | ||
| if isinstance(state_dict, str): |
Owner
There was a problem hiding this comment.
Can we make it clearer that we are saying this is a valid path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor load_state_dict method to accept state_dict directly and handle string input.