Repository navigation
Add more comments to sample code - #25
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds instructional comments to sample code for an advertising SDK, providing guidance to developers on replacing placeholder values with their own provisioned IDs and parameters.
- Added comments instructing developers to replace app ID, org ID, and user ID placeholders
- Updated existing comments to be more descriptive and actionable
- Improved documentation for SDK initialization parameters and custom parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| NativeBannerMultiFormatActivity.kt | Added comments for app ID, org ID, and user ID parameters |
| InterstitialFormatActivity.kt | Added comments for app ID, org ID, and user ID parameters |
| BannerActivity.kt | Added comments for app ID, org ID, and user ID parameters with slight wording variations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| .setPlacement(placementId) | ||
| .setAdSize(AdSize(300, 250, false, false)) | ||
| .setCustomParams(mapOf("user_id" to "177905312")) | ||
| .setCustomParams(mapOf("user_id" to "177905312")) // Please replace with current app user id (ppid)) |
There was a problem hiding this comment.
Extra closing parenthesis in comment - should be single closing parenthesis.
| .setCustomParams(mapOf("user_id" to "177905312")) // Please replace with current app user id (ppid)) | |
| .setCustomParams(mapOf("user_id" to "177905312")) // Please replace with current app user id (ppid) |
| // 1. init MSP SDK | ||
| val initParams = object : MSPInitializationParameters { | ||
| override fun getAppId(): Int { | ||
| // Please replace with your own provisioned app id |
There was a problem hiding this comment.
[nitpick] Comment wording is inconsistent with other files. Should use 'current' instead of 'your own' to match the pattern used in other activity files.
| // Please replace with your own provisioned app id | |
| // Please replace with current provisioned app id |
| } | ||
|
|
||
| override fun getOrgId(): Int { | ||
| // Please replace with your own provisioned org id |
There was a problem hiding this comment.
[nitpick] Comment wording is inconsistent with other files. Should use 'current' instead of 'your own' to match the pattern used in other activity files.
| // Please replace with your own provisioned org id | |
| // Please replace with current provisioned org id |
No description provided.