Skip to content

Revert "Sync with upstream prebid-server v4.9.0 (#137)" - #139

Merged
fushouli merged 1 commit into
msp-2506from
revert-v4.9.0-sync
Sep 28, 2026
Merged

fushouli merged 1 commit into
msp-2506from
revert-v4.9.0-sync

Conversation

@zwl-williamzha

Copy link
Copy Markdown

Reverts #137 and #138. #138 fixed a v4-only regression in the module-context code that #137 brought in, and it does not apply without #137.

The resulting tree is identical to ad5ae87 (#135), the last commit before the sync (git diff ad5ae8722 HEAD is empty).

Merging this changes nothing on its own: MSP pins the submodule and imports prebid-server/v4. A companion MSP PR reverts ParticleMedia/msp#3211 and prebid#3212 and moves the pointer here.

🤖 Generated with Claude Code

Reverts #137 and #138, which fixed a v4-only regression in the module
context code #137 brought in and does not apply without it. The tree is
identical to ad5ae87 (#135), the last commit before the sync.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

whiteSpace := regexp.MustCompile(`\s+`)

bidder := &AdOceanAdapter{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can call this simply "adapter", the AdOceanAdapter identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be AdOceanAdapter.AdOceanAdapter which looks a little redundant. See example below:

  package foo

  type adapter struct {
    endpoint string
  }
  
  func  Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
    return &adapter{endpoint: "https://www.foo.com"}, nil
  }

}

bidder := &adapter{
bidder := &AdopplerAdapter{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can call this simply "adapter", the AdopplerAdapter identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be AdopplerAdapter.AdopplerAdapter which looks a little redundant. See example below:

  package foo

  type adapter struct {
    endpoint string
  }
  
  func  Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
    return &adapter{endpoint: "https://www.foo.com"}, nil
  }

@fushouli
fushouli merged commit 509ea8b into msp-2506 Sep 28, 2026
1 check failed
@fushouli
fushouli deleted the revert-v4.9.0-sync branch September 28, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants