Repository navigation
Revert "Sync with upstream prebid-server v4.9.0 (#137)" - #139
Merged
Merged
Conversation
|
|
||
| whiteSpace := regexp.MustCompile(`\s+`) | ||
|
|
||
| bidder := &AdOceanAdapter{ |
There was a problem hiding this comment.
You can call this simply "adapter", the AdOceanAdapter identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be AdOceanAdapter.AdOceanAdapter which looks a little redundant. See example below:
package foo
type adapter struct {
endpoint string
}
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
return &adapter{endpoint: "https://www.foo.com"}, nil
}
| } | ||
|
|
||
| bidder := &adapter{ | ||
| bidder := &AdopplerAdapter{ |
There was a problem hiding this comment.
You can call this simply "adapter", the AdopplerAdapter identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be AdopplerAdapter.AdopplerAdapter which looks a little redundant. See example below:
package foo
type adapter struct {
endpoint string
}
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
return &adapter{endpoint: "https://www.foo.com"}, nil
}
fushouli
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #137 and #138. #138 fixed a v4-only regression in the module-context code that #137 brought in, and it does not apply without #137.
The resulting tree is identical to ad5ae87 (#135), the last commit before the sync (
git diff ad5ae8722 HEADis empty).Merging this changes nothing on its own: MSP pins the submodule and imports
prebid-server/v4. A companion MSP PR reverts ParticleMedia/msp#3211 and prebid#3212 and moves the pointer here.🤖 Generated with Claude Code