Repository navigation
displayio: send iPadOS traffic as device.os "iOS" - #144
Merged
Merged
Conversation
Display.io reported receiving "os": "iPadOS" for iPad traffic and asked for it to arrive as "iOS". MakeRequests now swaps the OS on a copy of the Device, so the shared request (also handed to MakeBids, and to other bidders) keeps "iPadOS". osv, make and model pass through unchanged, so iPads stay distinguishable by model. New supplemental fixture ipados-os.json fails without the change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
fushouli
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display.io reported that MSP sends
"os": "iPadOS"for iPad traffic and asked for it to arrive as"iOS".Change
MakeRequestsmapsdevice.os"iPadOS"→"iOS"on a copy of theDevice, set on the per-imp request copy it already builds. The shared request keeps"iPadOS": it is also handed toMakeBids, other bidders read the sameDevicepointer, and the adapter test harness fails on mutation.osv,makeandmodelpass through unchanged, so iPads stay distinguishable bymodel. Every other OS value is sent as before.Test
New
displayiotest/supplemental/ipados-os.jsonasserts the outgoing body carries"os": "iOS"with the rest of the device untouched. It fails without the change;go test ./adapters/displayio/passes with it.🤖 Generated with Claude Code