Skip to content

Fix logging config import and guard against IndexError in EndpointFilter #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zZedix wants to merge 2 commits into from
Closed

Fix logging config import and guard against IndexError in EndpointFilter #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a7a1f2
added the missing logging.config import so dictConfig runs properly a…
zZedix Oct 10, 2025
18c474f
Fix mutable default arguments in XRay constructor to prevent config s…
zZedix Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/core/xray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@
class XRayConfig(dict):
def __init__(
self,
config: Union[dict, str, PosixPath] = {},
exclude_inbound_tags: set[str] | None = set(),
fallbacks_inbound_tags: set[str] | None = set(),
config: Union[dict, str, PosixPath] | None = None,
exclude_inbound_tags: set[str] | None = None,
fallbacks_inbound_tags: set[str] | None = None,
):
"""Initialize the XRay config."""
if config is None:
config = {}
if isinstance(config, str):
# considering string as json
config = commentjson.loads(config)
Expand Down
3 changes: 2 additions & 1 deletion app/utils/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import logging.config
from copy import copy
from urllib.parse import unquote

Expand Down Expand Up @@ -88,7 +89,7 @@ def __init__(self, excluded_endpoints: list[str]):
self.excluded_endpoints = excluded_endpoints

def filter(self, record: logging.LogRecord) -> bool:
if record.args and len(record.args) >= 2:
if record.args and len(record.args) >= 3:
path = unquote(record.args[2])
return path not in self.excluded_endpoints
return True