-
Notifications
You must be signed in to change notification settings - Fork 403
feat: Add final_mask_settings to hosts #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5e6a9ca
feat: Add a new finalmask params
ImMohammad20000 c30326a
Merge branch 'dev' into final-mask-builder
ImMohammad20000 9b08386
Add final_mask_settings to hosts
ImMohammad20000 f42615b
fix: type in finalmask object
ImMohammad20000 e5c0ea1
Merge branch 'dev' into final-mask-builder
ImMohammad20000 9cb6db0
fix: migrations
ImMohammad20000 4dcd1d0
fix: migrations revises id
ImMohammad20000 9108354
fix: import missing type
ImMohammad20000 a5f0aac
fix: update hosts to code rabit suggest
ImMohammad20000 89f1fc7
Merge branch 'dev' into final-mask-builder
ImMohammad20000 089d650
Update f976bfcf4738_add_final_mask_settings_to_hosts_table.py
ImMohammad20000 2fc532c
Merge branch 'dev' into final-mask-builder
ImMohammad20000 c4d8d72
fix import
ImMohammad20000 b9b8c67
fix migrations
ImMohammad20000 0598ace
fix
ImMohammad20000 870f713
fix: Dump FinalMask with aliases
ImMohammad20000 f89c028
feat: Add final mask settings to hosts modals in dashboard
ImMohammad20000 ea2f9bd
refactor(hosts): improve FinalMask settings type safety and reduce co…
x0sina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
app/db/migrations/versions/f976bfcf4738_add_final_mask_settings_to_hosts_table.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| """add final_mask_settings to hosts table | ||
|
|
||
| Revision ID: f976bfcf4738 | ||
| Revises: b6c9d0e1f2a3 | ||
| Create Date: 2026-05-02 13:46:21.008567 | ||
|
|
||
| """ | ||
| from alembic import op | ||
| import sqlalchemy as sa | ||
|
|
||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = 'f976bfcf4738' | ||
| down_revision = 'b6c9d0e1f2a3' | ||
| branch_labels = None | ||
| depends_on = None | ||
|
ImMohammad20000 marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| with op.batch_alter_table('hosts', schema=None) as batch_op: | ||
| batch_op.add_column(sa.Column('final_mask_settings', sa.JSON(none_as_null=True), nullable=True)) | ||
|
|
||
| # ### end Alembic commands ### | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| with op.batch_alter_table('hosts', schema=None) as batch_op: | ||
| batch_op.drop_column('final_mask_settings') | ||
|
|
||
| # ### end Alembic commands ### | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.