Skip to content

Potential fix for code scanning alert no. 2: Incomplete URL substring sanitization #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M03ED merged 1 commit into from
Sep 25, 2025
Merged

Potential fix for code scanning alert no. 2: Incomplete URL substring sanitization #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/models/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from datetime import datetime
from decimal import Decimal
from typing import Optional
from urllib.parse import urlparse

from app.db.models import UserStatusCreate

Expand Down Expand Up @@ -173,8 +174,11 @@ def validate_proxy_url(value: str | None) -> str | None:
class DiscordValidator:
@staticmethod
def validate_webhook(value: str | None):
if value and not value.startswith("https://discord.com"):
raise ValueError("Discord webhook must start with 'https://discord.com'")
if value:
parsed = urlparse(value)
# validate scheme and hostname
if parsed.scheme != "https" or parsed.hostname not in {"discord.com"}:
raise ValueError("Discord webhook must use https scheme and point to 'discord.com'")
return value


Expand Down