feat(subscription): recognize InHive → xray (full config), not sing_box (#658 follow-up) - #689
Merged
ImMohammad20000 merged 2 commits intoJul 14, 2026
Conversation
…asarGuard#658 follow-up) Follow-up to PasarGuard#658. The sing_box generator (app/subscription/singbox.py) drops kcp/xhttp/splithttp. InHive is a universal client that ingests raw share-links natively, so removing it from the sing_box rule lets its UA fall through to the links_base64 catch-all — the full, unstripped format. Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughThe migration removes InHive matching from the ChangesSing-box and InHive routing
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to PasarGuard#658. Instead of silently falling through to the links_base64 catch-all, add an explicit InHive rule targeting the xray generator, which carries the full transport set (xhttp/kcp/reality/hysteria2) — same intent as Happ getting structured configs. The sing_box generator drops kcp/xhttp/splithttp. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to my earlier merged PR #658, which added
[Ii]n[Hh]iveto the defaultsing_boxrule. That was the wrong target — thesing_boxgenerator (app/subscription/singbox.py) drops kcp/xhttp/splithttp:InHive is a universal client (a sing-box fork with Xray-parity) that ingests raw share-links and Xray-JSON natively. This PR:
InHivefrom thesing_boxrule.^[Ii]n[Hh]ive→xrayrule, so InHive is recognized by name and served the full Xray config (app/subscription/xray.pycarries xhttp/splithttp, kcp, quic, reality, Hysteria2, WireGuard — no transport stripping).This mirrors how Happ is handled elsewhere (recognized explicitly, served a full config) rather than relying on the catch-all.
Notes
sing_boxrule from subscription settings.X-HWIDheader, so device-limit accounting is unchanged.Summary by CodeRabbit