This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Add classes and fields to ForgeHooks, which might be used by hacky mods#161
Merged
TheGlitch76 merged 1 commit intomasterfrom Jul 30, 2020
Merged
Add classes and fields to ForgeHooks, which might be used by hacky mods#161TheGlitch76 merged 1 commit intomasterfrom
TheGlitch76 merged 1 commit intomasterfrom
Conversation
Contributor
|
Don't have to deal with this right now, but I wonder how #139 would change things, since that isn't using the LootTableContext struct anymore internally. EDIT: it would work, but kinda only coincidentally since it's setting the name, which is the only thing the relevant hook looks for in that PR. :/ Overall, the changes here make sense to me. |
florensie
changed the title
TheGlitch76
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix makes https://github.com/MinecraftModDevelopmentMods/AdditionalLootTables/tree/master-1.15.2 work.
By design, AdditionalLootTables 1.15.2 should also work in 1.14.4. Without coremoding, in order to append items to an existing loottable, Forge mods have to use reflection on
ForgeHooks.lootContext.