This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Closed
Conversation
Contributor
Author
|
Before I forget, I'm gonna change the annotation next time I work on this so you always include the name of the item you're adding, to make it easier to search for the items. basically the biggest upside to this method is also its biggest downside, in that everything is spread everywhere. |
Contributor
Author
|
Closing in favor of #203. I wouldn't mind revisiting this again another time, but at the moment I feel the biggest upside of this is also it's biggest disadvantage, and the other method is less likely to bite us in the ass later. i think. i hope. |
Contributor
Author
|
reopening i guess since at least @famous1622 is still interested in this. |
This was referenced Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically my first working version of stuff. depends on #201 , as it uses an annotationProcessor defined in a subproject and makes use of the precompiled script plugins to make it easier to e.g. disable checkstyle for a particular module.
Where to go from here: (ideas listed in order of most to least tempting)