test: give the cross-instance ticket test a load-proof budget - #4
Merged
Merged
Conversation
`allows only one winner across independent store instances` drives 8 independent store instances through the real filesystem across 12 rounds, so it measures cross-instance atomicity rather than latency. It needs ~3.9s locally, which the default 5s budget turns into a flake on a loaded CI runner. That flake failed PR #3's verify job once and then failed the v0.2.6 release source-gate, which runs the whole localapp suite before it will build anything. Raise only this test's timeout; the assertions stay as they are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flake that blocked the v0.2.6 release.
tests/click-ticket-store.test.ts > allows only one winner across independent store instancesdrives 8 independentDeliveryStoreinstances through the real filesystem across 12 rounds, so it measures cross-instance atomicity rather than latency. Measured locally at ~3.9s against the default 5s budget — close enough that a loaded runner times out.It has now cost two CI cycles:
verifyrun failed on it (a rerun passed).source-gatefailed on it. That gate runspnpm -C packages/localapp testbefore it will build or publish anything, so it blocks releases.Only this test's timeout changes; the assertions are untouched.