Skip to content

Added --solid #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diesphink wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added --solid #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 41 additions & 39 deletions gfthings/Bin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def __init__(self, width : int, depth : int,
lip : bool = True,
rotation: tuple[float, float, float] | Rotation = (0, 0, 0),
label: bool = True,
solid: bool = False,
align: Align | tuple[Align, Align, Align] = None,
mode: Mode = Mode.ADD):
import math
Expand All @@ -188,46 +189,47 @@ def __init__(self, width : int, depth : int,
magnet_depth=magnet_depth,
align=(Align.CENTER, Align.CENTER, Align.MAX))

inner_width = width * bin_size - bin_clearance*2 - wall_thickness*2
inner_depth = depth * bin_size - bin_clearance*2 - wall_thickness*2
with BuildSketch(faces().filter_by(Plane.XY).sort_by(Axis.Z)[-1]):
RectangleRounded(inner_width, inner_depth,
radius=outer_rad - bin_clearance -
wall_thickness)

inner_height = wall_height
if width > 1 or depth > 1 or half_grid:
# For a bin that covers more than one square we need a floor
# to connect the squares.
inner_height -= wall_thickness
extrude(amount=-inner_height, mode=Mode.SUBTRACT)

inner_front_centre = faces().filter_by(Plane.XY) \
.sort_by(Axis.Z)[-2].edges().filter_by(Axis.X) \
.sort_by(Axis.Y)[0]@0.5

# This fillet rounds off the floor of the bin nicely.
inner_fillet_rad=7.5/2 - wall_thickness
if inner_height == wall_height:
# It is it can also prevent the wall-base corner from being too thin.
inner_fillet_rad = max(inner_fillet_rad, wall_thickness)
if inner_fillet_rad:
fillet(faces().filter_by(Plane.XY).sort_by(Axis.Z)[-2].edges(), radius=inner_fillet_rad)
if divisions > 1:
dividors = divisions-1
dividor_space = inner_width / divisions
with Locations(inner_front_centre):
with GridLocations(dividor_space, 1, dividors, 1):
# Use inner_height if there's no shelf, otherwise
# subtract the shelf's cuttout depth.
Box(wall_thickness, inner_depth, inner_height - 1.1,
align=(Align.CENTER, Align.MIN, Align.MIN))
if not solid:
inner_width = width * bin_size - bin_clearance*2 - wall_thickness*2
inner_depth = depth * bin_size - bin_clearance*2 - wall_thickness*2
with BuildSketch(faces().filter_by(Plane.XY).sort_by(Axis.Z)[-1]):
RectangleRounded(inner_width, inner_depth,
radius=outer_rad - bin_clearance -
wall_thickness)

inner_height = wall_height
if width > 1 or depth > 1 or half_grid:
# For a bin that covers more than one square we need a floor
# to connect the squares.
inner_height -= wall_thickness
extrude(amount=-inner_height, mode=Mode.SUBTRACT)

inner_front_centre = faces().filter_by(Plane.XY) \
.sort_by(Axis.Z)[-2].edges().filter_by(Axis.X) \
.sort_by(Axis.Y)[0]@0.5

# This fillet rounds off the floor of the bin nicely.
inner_fillet_rad=7.5/2 - wall_thickness
if inner_height == wall_height:
# It is it can also prevent the wall-base corner from being too thin.
inner_fillet_rad = max(inner_fillet_rad, wall_thickness)
if inner_fillet_rad:
fillet(faces().filter_by(Plane.XY).sort_by(Axis.Z)[-2].edges(), radius=inner_fillet_rad)
if divisions > 1:
dividors = divisions-1
dividor_space = inner_width / divisions
with Locations(inner_front_centre):
with GridLocations(dividor_space, 1, dividors, 1):
# Use inner_height if there's no shelf, otherwise
# subtract the shelf's cuttout depth.
Box(wall_thickness, inner_depth, inner_height - 1.1,
align=(Align.CENTER, Align.MIN, Align.MIN))

if scoop_rad and scoop_rad > 0:
with Locations(inner_front_centre):
Scoop(scoop_rad, inner_width, inner_height,
wall_thickness, shelf_clearance,
align=(Align.CENTER, Align.MIN, Align.MIN))
if scoop_rad and scoop_rad > 0:
with Locations(inner_front_centre):
Scoop(scoop_rad, inner_width, inner_height,
wall_thickness, shelf_clearance,
align=(Align.CENTER, Align.MIN, Align.MIN))

if lip:
with Locations((0, 0, wall_height/2 + plate_height)):
Expand Down
17 changes: 16 additions & 1 deletion gfthings/gfbin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ def main(argv: list[str] | None = None):
"scoops and divisions aren't supported.",
type=str,
default="")
parser.add_argument(
"--solid",
help="Create a solid gridfinity bin. This is useful to make " +
"the base for further modeling and carve out the bin as "
"needed.",
action="store_true")

args = parser.parse_args(argv)

Expand Down Expand Up @@ -155,6 +161,10 @@ def main(argv: list[str] | None = None):
bin = None
funky = args.funky
if funky != "":
if args.solid:
print("Funky bins don't support the solid option.")
exit(1)

if funky == "donut":
funky_expr = [[True, True, True],
[True, False, True],
Expand Down Expand Up @@ -189,6 +199,10 @@ def main(argv: list[str] | None = None):
half_grid=args.half_grid,
wall_thickness=args.wall_thickness)
elif args.half_wall:
if args.solid:
print("Half wall bins don't support the solid option.")
exit(1)

bin = HalfWallBin(x, y, z,
divisions=divisions,
lip=not args.no_lip,
Expand All @@ -207,7 +221,8 @@ def main(argv: list[str] | None = None):
magnet_dia=args.magnet_dia,
magnet_depth=args.magnet_height,
half_grid=args.half_grid,
wall_thickness=args.wall_thickness)
wall_thickness=args.wall_thickness,
solid=solid)

if args.vscode:
from ocp_vscode import (show_object,
Expand Down