Skip to content

Fix GitHub OAuth callback sessions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pavilion-devs merged 1 commit into from
Aug 11, 2026
Merged

Fix GitHub OAuth callback sessions #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions deploy/production/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,12 @@ absent from the production image. The release check requires a zero-finding
reference pair is `glassboxhq.xyz` and `app.glassboxhq.xyz`.
3. A GitHub OAuth App whose callback is
`https://app.glassboxhq.xyz/oauth2/callback` (replace the host for another domain).
The reference proxy requests only `user:email`. Any authenticated GitHub user
becomes a read-only viewer; only usernames in `GITHUB_ADMIN_USERS` may change
the DataHub connection or issue and revoke ingestion keys.
The reference proxy requests `user:email read:org`. OAuth2 Proxy's GitHub
provider resolves organization membership while creating every session, so
`read:org` is required even though GlassBox does not restrict sign-in by
organization. Any authenticated GitHub user becomes a read-only viewer; only
usernames in `GITHUB_ADMIN_USERS` may change the DataHub connection or issue
and revoke ingestion keys.
4. A scoped DataHub service account that can read catalog entities and upsert the
GlassBox Document/Incident aspects used by the compiler and invalidation Action.
5. A receipt signing key and matching operator trust policy.
Expand Down
4 changes: 3 additions & 1 deletion deploy/production/compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ services:
OAUTH2_PROXY_EMAIL_DOMAINS: "*"
# Authentication is open to any GitHub account. Authorization remains in
# GlassBox: authenticated users are viewers unless explicitly named below.
OAUTH2_PROXY_SCOPE: user:email
# OAuth2 Proxy still resolves GitHub organization membership while creating
# every session, so read:org is required even without an organization gate.
OAUTH2_PROXY_SCOPE: user:email read:org
OAUTH2_PROXY_REVERSE_PROXY: "true"
OAUTH2_PROXY_SET_XAUTHREQUEST: "true"
OAUTH2_PROXY_SKIP_PROVIDER_BUTTON: "true"
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_production_edge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ def test_compose_binds_public_and_console_hosts_to_distinct_boundaries() -> None
"https://${GLASSBOX_CONSOLE_DOMAIN:?set GLASSBOX_CONSOLE_DOMAIN}/oauth2/callback" in compose
)
assert "--github-user" not in compose
assert "OAUTH2_PROXY_SCOPE: user:email" in compose
assert "OAUTH2_PROXY_SCOPE: user:email read:org" in compose
assert "GLASSBOX_ADMIN_USERS: ${GITHUB_ADMIN_USERS:-}" in compose
assert "GITHUB_ALLOWED_USERS" not in compose