注意書きを追記した - #47
Conversation
chore: add warning message
There was a problem hiding this comment.
Pull request overview
This pull request adds a comprehensive disclaimer notice to inform users about the development status of Pay Crew2 and potential risks. The disclaimer warns users about possible data loss, specification changes, and includes a liability waiver.
Changes:
- Extended the existing disclaimer message in Root page to include detailed warnings about data loss and specification changes
- Added the same comprehensive disclaimer to the Login page
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| products/frontend/src/routes/Root/index.tsx | Updated the Error component content to include extended disclaimer about data loss risks and liability waiver |
| products/frontend/src/routes/Login/index.tsx | Added Error component import and displayed the comprehensive disclaimer on the login page |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <> | ||
| <Logo content="Pay Crew2" /> | ||
| <Error content="Pay Crew2は、まだ開発中です。" /> | ||
| <Error content="Pay Crew2は、まだ開発中です。そのため、予告なくデータが消失する可能性があります。また、サービスの仕様が変更されることがあります。これらを含む「Pay Crew2」について、一切の責任を負いかねますのでご了承ください。" /> |
There was a problem hiding this comment.
The disclaimer message is hardcoded and duplicated across multiple files (Root/index.tsx and Login/index.tsx). Consider extracting this long disclaimer text into a shared constant to ensure consistency and make future updates easier. For example, create a constants file with export const DEVELOPMENT_DISCLAIMER = '...' and import it where needed.
| return ( | ||
| <div> | ||
| <Title title="ログイン" /> | ||
| <Error content="Pay Crew2は、まだ開発中です。そのため、予告なくデータが消失する可能性があります。また、サービスの仕様が変更されることがあります。これらを含む「Pay Crew2」について、一切の責任を負いかねますのでご了承ください。" /> |
There was a problem hiding this comment.
The disclaimer message is hardcoded and duplicated across multiple files (Root/index.tsx and Login/index.tsx). Consider extracting this long disclaimer text into a shared constant to ensure consistency and make future updates easier. For example, create a constants file with export const DEVELOPMENT_DISCLAIMER = '...' and import it where needed.
| <> | ||
| <Logo content="Pay Crew2" /> | ||
| <Error content="Pay Crew2は、まだ開発中です。" /> | ||
| <Error content="Pay Crew2は、まだ開発中です。そのため、予告なくデータが消失する可能性があります。また、サービスの仕様が変更されることがあります。これらを含む「Pay Crew2」について、一切の責任を負いかねますのでご了承ください。" /> |
There was a problem hiding this comment.
The Error component is being used to display a disclaimer/warning message, but based on its usage elsewhere in the codebase (error states, failed data fetches), it appears to be designed for error messages. Consider creating a dedicated Warning or Disclaimer component for this use case to maintain semantic clarity and allow for different styling if needed.
| return ( | ||
| <div> | ||
| <Title title="ログイン" /> | ||
| <Error content="Pay Crew2は、まだ開発中です。そのため、予告なくデータが消失する可能性があります。また、サービスの仕様が変更されることがあります。これらを含む「Pay Crew2」について、一切の責任を負いかねますのでご了承ください。" /> |
There was a problem hiding this comment.
The Error component is being used to display a disclaimer/warning message, but based on its usage elsewhere in the codebase (error states, failed data fetches), it appears to be designed for error messages. Consider creating a dedicated Warning or Disclaimer component for this use case to maintain semantic clarity and allow for different styling if needed.
No description provided.