chore: add terms and privacy policy - #60
Merged
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
chore: add role
chore: add terms and privacy policy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds legal documentation (terms of service and privacy policy) to the Pay Crew2 application and improves accessibility across various UI components. The PR title mentions "chore: add terms and privacy policy" which aligns with the primary content changes.
Changes:
- Added comprehensive Japanese terms of service and privacy policy documents
- Enhanced accessibility by adding ARIA attributes to Loading and Error components
- Added
role="none"to a dummy DOM element in the History component for better accessibility
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| products/frontend/src/share/Loading/index.tsx | Added aria-hidden="true" to decorative loader and role="status" with aria-live="polite" to loading message for screen reader support |
| products/frontend/src/share/Error/index.tsx | Added aria-hidden="true" to decorative loader and role="alert" with aria-live="assertive" and aria-atomic="true" to error message for proper screen reader announcements |
| products/frontend/src/routes/Terms/index.tsx | Replaced placeholder content with complete Japanese terms of service including service definition, user obligations, prohibited activities, and liability disclaimers |
| products/frontend/src/routes/Privacy/index.tsx | Replaced placeholder content with complete Japanese privacy policy covering data collection, usage, security, and user rights |
| products/frontend/src/routes/GroupDetail/components/History/index.tsx | Added role="none" to a dummy div element to explicitly mark it as presentational for accessibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 当開発チームは、取得した個人情報を、以下の目的のために利用します。 | ||
| 1. 本サービスの提供、運営、維持、改善のため | ||
| 2. 利用者認証のため | ||
| 3. 貸し借りの登録、共通の台帳管理、複数のグループを越えた個人間の貸し借りの合算、登録された台帳奇特の返金処理、返金処理の取り消しといった本サービスの機能を提供するため |
There was a problem hiding this comment.
Typo found in the text. The phrase "台帳奇特の返金処理" should be "台帳記録の返金処理". The word "奇特" (bizarre/unusual) should be "記録" (record) to match the terminology used throughout the terms and privacy documents.
Suggested change
| 3. 貸し借りの登録、共通の台帳管理、複数のグループを越えた個人間の貸し借りの合算、登録された台帳奇特の返金処理、返金処理の取り消しといった本サービスの機能を提供するため | |
| 3. 貸し借りの登録、共通の台帳管理、複数のグループを越えた個人間の貸し借りの合算、登録された台帳記録の返金処理、返金処理の取り消しといった本サービスの機能を提供するため |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.