Skip to content

sample - #63

Merged
Myxogastria0808 merged 9 commits into
mainfrom
dev
Jan 23, 2026
Merged

sample#63
Myxogastria0808 merged 9 commits into
mainfrom
dev

Conversation

@Myxogastria0808

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 23, 2026 17:18
@Myxogastria0808
Myxogastria0808 merged commit 7f99bc1 into main Jan 23, 2026
12 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes user profile fields (avatar_url and bio) from the application and introduces frontend enhancements including a Date component for displaying policy dates and a WelcomeMessage component for the root page. The PR also adds a PWA manifest and deletes the AI.md specification file.

Changes:

  • Removed avatar_url and bio fields from user profile schema, database, backend API, and frontend components
  • Added reusable Date component for displaying dates on Terms and Privacy pages
  • Added WelcomeMessage component to greet users on the root page
  • Added PWA manifest.json with app metadata and icons
  • Removed AI.md specification document

Reviewed changes

Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
products/validator/src/response/userProfile.ts Removed avatar_url and bio fields from response schema
products/validator/src/request/userProfile.ts Removed avatar_url and bio fields from request schema
products/backend/src/db/auth-schema.ts Removed avatarUrl and bio columns from user table
products/backend/src/presentation/routes/userProfile.ts Updated getUserProfile and updateUserProfile to remove avatar_url and bio handling
products/frontend/src/share/Date/index.tsx Added new Date component (with naming issues)
products/frontend/src/share/index.ts Exported new Date component
products/frontend/src/routes/Terms/index.tsx Updated to use Date component
products/frontend/src/routes/Privacy/index.tsx Updated to use Date component
products/frontend/src/routes/Root/index.tsx Added WelcomeMessage component and session check for username
products/frontend/src/routes/Root/components/WelcomeMessgae/index.tsx Added WelcomeMessage component (directory misspelled)
products/frontend/src/routes/Root/components/index.ts Exported WelcomeMessage with misspelled path
products/frontend/src/routes/Profile/index.tsx Removed avatar_url and bio form fields
products/frontend/src/routes/Share/components/Footer/index.tsx Added title link to footer
products/frontend/src/api/openapi.d.ts Updated API types to reflect schema changes
products/frontend/openapi.json Updated OpenAPI spec to reflect schema changes
products/frontend/public/manifest.json Added PWA manifest
assets/er.mmd Updated ER diagram to remove avatar_url and bio fields
assets/er.png Updated ER diagram image
AI.md Deleted specification document

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +9 to +13
const Error: FC<Props> = (props: Props) => {
return <small className={styles.date}>{props.content}</small>;
};

export default Error;

Copilot AI Jan 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component name in the export statement doesn't match the actual component name. The file exports 'Error' but should export 'Date' to match the component definition on line 9.

Suggested change
const Error: FC<Props> = (props: Props) => {
return <small className={styles.date}>{props.content}</small>;
};
export default Error;
const Date: FC<Props> = (props: Props) => {
return <small className={styles.date}>{props.content}</small>;
};
export default Date;

Copilot uses AI. Check for mistakes.
Comment on lines +9 to +13
const Error: FC<Props> = (props: Props) => {
return <small className={styles.date}>{props.content}</small>;
};

export default Error;

Copilot AI Jan 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component name 'Error' should be 'Date' to match the intended functionality and the export from the parent index. This component is meant to display dates, not errors.

Suggested change
const Error: FC<Props> = (props: Props) => {
return <small className={styles.date}>{props.content}</small>;
};
export default Error;
const Date: FC<Props> = (props: Props) => {
return <small className={styles.date}>{props.content}</small>;
};
export default Date;

Copilot uses AI. Check for mistakes.
export { default as Lent } from './Lent';
export { default as Borrow } from './Borrow';
export { default as Group } from './Group';
export { default as WelcomeMessage } from './WelcomeMessgae';

Copilot AI Jan 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory name is misspelled. It should be 'WelcomeMessage' to match the exported component name, not 'WelcomeMessgae' (missing 'a' in 'Message').

Suggested change
export { default as WelcomeMessage } from './WelcomeMessgae';
export { default as WelcomeMessage } from './WelcomeMessage';

Copilot uses AI. Check for mistakes.
},
});
useEffect(() => {
sessionCheckMutation.mutate({ credentials: 'include' });

Copilot AI Jan 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useEffect hook has a missing dependency. The 'sessionCheckMutation' should be included in the dependency array, or alternatively, you should extract the mutate function. However, since this is a mutation that should only run once on mount, the current implementation with an empty dependency array may be intentional. If so, consider adding an ESLint disable comment to make the intent clear, or restructure to avoid the warning.

Suggested change
sessionCheckMutation.mutate({ credentials: 'include' });
sessionCheckMutation.mutate({ credentials: 'include' });
// eslint-disable-next-line react-hooks/exhaustive-deps

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants