Skip to content

[Snyk] Fix for 2 vulnerabilities #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MManke188 wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −27
Open

[Snyk] Fix for 2 vulnerabilities #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 20 additions & 25 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@
"@angular/animations": "^17.3.1",
"@angular/cli": "^17.3.1",
"@angular/common": "^17.3.1",
"@angular/compiler": "^17.3.1",
"@angular/core": "^17.3.1",
"@angular/compiler": "^19.2.18",
"@angular/core": "^19.2.18",
Comment on lines +69 to +70
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading only @angular/compiler and @angular/core to version 19.2.18 while keeping all other Angular packages at version 17.3.1 creates a severe version mismatch. Angular requires all framework packages to be on the same major version. This configuration will likely cause runtime errors, compilation failures, and unpredictable behavior.

All Angular packages should be upgraded together, including:

  • @angular-devkit/build-angular
  • @angular/animations
  • @angular/cli
  • @angular/common
  • @angular/forms
  • @angular/localize
  • @angular/platform-browser
  • @angular/platform-browser-dynamic
  • @angular/platform-server
  • @angular/router
  • @angular/ssr
  • @angular/compiler-cli (in devDependencies)
  • @angular/language-service (in devDependencies)
Suggested change
"@angular/compiler": "^19.2.18",
"@angular/core": "^19.2.18",
"@angular/compiler": "^17.3.1",
"@angular/core": "^17.3.1",

Copilot uses AI. Check for mistakes.
Comment on lines +69 to +70
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading only @angular/compiler and @angular/core to version 19.2.18 creates multiple critical compatibility issues:

  1. Angular Framework Version Mismatch: All other Angular packages remain at version 17.3.1 (@angular/animations, @angular/cli, @angular/common, @angular/forms, @angular/localize, @angular/platform-browser, @angular/platform-browser-dynamic, @angular/platform-server, @angular/router, @angular/ssr, @angular/compiler-cli, @angular/language-service). Angular requires all framework packages to be on the same major version to function correctly.

  2. zone.js Peer Dependency Mismatch: Angular 19 requires zone.js ~0.15.0, but the current package.json specifies zone.js "~0.14.4".

  3. Third-party Angular Package Incompatibilities: Several Angular-dependent packages are incompatible with Angular 19:

    • @ng-bootstrap/ng-bootstrap at version 16.0.0 (designed for Angular 16)
    • ngx-echarts at version 17.2.0 (designed for Angular 17)
    • ngx-infinite-scroll at version 17.0.0 (designed for Angular 17)

This partial upgrade will cause compilation failures, runtime errors, and unpredictable behavior. A complete Angular upgrade strategy is required, upgrading all Angular packages and their dependencies together.

Suggested change
"@angular/compiler": "^19.2.18",
"@angular/core": "^19.2.18",
"@angular/compiler": "^17.3.1",
"@angular/core": "^17.3.1",

Copilot uses AI. Check for mistakes.
"@angular/forms": "^17.3.1",
"@angular/localize": "^17.3.1",
"@angular/platform-browser": "^17.3.1",
Expand Down
Loading