Preserve cell bboxes across multi-page merge and add row-level page map - #19
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Engine team's report: every
TableCellin a merged multi-page table came back withbbox=None, blocking word-level grounding._reemit_body_rownow carries the source cell'sbboxinto the rebuilt cell; untouched body rows keep their geometry. The FIFO alignment between repeated identical-text rows and their source occurrences is documented as a load-bearing invariant.LogicalTable.row_pages(grid row index → resolvedpage_no) records which page each row's boxes are valid on — shape per Engine's review: resolved page numbers over prov indices, dict over list, missing key = no single source page.TableStitcher.last_logical_tablesexposes the merge results, previously discarded after injection.Verified end-to-end on the 15-page druglist fixture: all 500 grid rows mapped across pages 1–15, 1,444/1,500 cells carrying a bbox (previously 0).
🤖 Generated with Claude Code