fix(disk-move): add 'delete source' checkbox to Move Disk dialog#58
Open
ry-ops wants to merge 1 commit intoPegaProx:mainfrom
Open
fix(disk-move): add 'delete source' checkbox to Move Disk dialog#58ry-ops wants to merge 1 commit intoPegaProx:mainfrom
ry-ops wants to merge 1 commit intoPegaProx:mainfrom
Conversation
Previously the Move Disk modal silently called the API with no `delete`
param, leaving the backend to apply its default (delete=True). The user
had no choice: they had to go into the Proxmox UI or SSH to clean up the
old volume themselves.
- Add `deleteSource` state (defaults to `true`) and a checkbox in
`MoveDiskModal` so users can opt out of deleting the source disk
- Fix hardcoded German strings in the modal title ("Festplatte
verschieben") and description ("von") — replaced with `t('moveDisk')`
and `t('from')`
- Propagate the flag through `handleMoveDisk` → `delete:` in the
JSON body (the existing `/disks/:id/move` backend already accepts this)
- Add EN/DE i18n keys: `moveDisk`, `deleteSourceDisk`
Fixes PegaProx#52
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52
The Move Disk modal gave users no control over whether the source volume was deleted after the move — it always used the backend default (delete=true). Users who wanted to keep the original had to go into the PVE UI or SSH to handle it manually.
deleteSourceboolean state (defaults totrue) and a checkbox inMoveDiskModalhandleMoveDisk→delete:in the JSON body (the existing/disks/:id/moveroute already accepts this field)t('moveDisk')andt('from')moveDisk,deleteSourceDiskTest plan
unused0in PVE🤖 Generated with Claude Code