fix(ssh): guard ssh_user extraction against None api_user#62
Open
ry-ops wants to merge 1 commit intoPegaProx:mainfrom
Open
fix(ssh): guard ssh_user extraction against None api_user#62ry-ops wants to merge 1 commit intoPegaProx:mainfrom
ry-ops wants to merge 1 commit intoPegaProx:mainfrom
Conversation
In 11 places the code derived the SSH username with:
ssh_user = api_user.split('@')[0] if '@' in api_user else api_user
If `api_user` is `None` (misconfigured cluster, corrupted DB row, or
unexpected API response) the `'@' in api_user` test raises TypeError and
the entire enclosing SSH operation fails with an unreadable traceback.
Consolidate all occurrences to the null-safe one-liner already used in
some newer code paths:
ssh_user = (api_user or 'root').split('@')[0]
This is equivalent for any non-None value and falls back to 'root' — the
expected Proxmox API user — when the value is absent.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In 11 places the code derived the SSH username with:
If
api_userisNone(misconfigured cluster, corrupted DB row, or unexpected API response), the'@' in api_usertest raisesTypeErrorand the entire SSH operation fails with an unreadable traceback instead of a meaningful error message.Fix: Consolidate all 11 occurrences to the null-safe one-liner already used in some newer code paths:
This is functionally identical for any non-None string value and falls back to
'root'— the expected Proxmox API user — when the value is absent.Test plan
TypeError🤖 Generated with Claude Code