Skip to content

Fix for the second-order PLM slope reconstruction. - #1056

Merged
d-montgomery merged 1 commit into
Pele-Suite:developmentfrom
magomedovs:development
Sep 1, 2026
Merged

Fix for the second-order PLM slope reconstruction.#1056
d-montgomery merged 1 commit into
Pele-Suite:developmentfrom
magomedovs:development

Conversation

@magomedovs

Copy link
Copy Markdown
Contributor

This MR fixes the second-order PLM slope reconstruction (MC-limited centered slope), which is selected by setting pelec.plm_iorder = 2. Previously, selecting this option resulted in the following relationship for the dtemp variable: dtemp = 4.0 / 3.0 * dcen rather than dtemp = dcen. This led to the overestimation of smooth slopes and the production of an artificial gradient steepening.
To reproduce the issue, run the "PeleC/Exec/RegTests/EB-C12" regression test case with pelec.do_mol = 0 and pelec.plm_iorder = 2.

@d-montgomery

Copy link
Copy Markdown
Collaborator

@magomedovs , thank you for opening up this PR and bringing this to our attention. I'm testing the changes now and reviewing the literature. I'll let you know if I have any questions.

@magomedovs

Copy link
Copy Markdown
Contributor Author

@magomedovs , thank you for opening up this PR and bringing this to our attention. I'm testing the changes now and reviewing the literature. I'll let you know if I have any questions.

Glad to be of help!

@d-montgomery

Copy link
Copy Markdown
Collaborator

I ran the RegTests/EB-C12 with pelec.do_mol = 0 and pelec.plm_iorder = 2 as you suggested and can confirm the artificial gradient steepening. Here are the results prior to this PR:

profiles_old

and after this PR:
profiles

Thanks @magomedovs for catching this! I still need to verify the test failures but should be able to get this merged quickly.

@d-montgomery d-montgomery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These EB test failures are expected as they all have do_mol = 0 with the default plm_iorder = 4. Whenever a cell is close enough to the EB surface where the 5-point stencil needed for 4th-order isn't fully available (but the 3-point stencil is), plm_iorder drops down to the 2nd order slope regardless of what plm_iorder was set to. Therefore, the diffs in these tests is a result of the fixed 2nd order slope.

@d-montgomery
d-montgomery merged commit c3f925c into Pele-Suite:development Sep 1, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants