surfchem - modified ck,py, production.py, utilities.py and converter.py - #486
surfchem - modified ck,py, production.py, utilities.py and converter.py#486jAnirudh wants to merge 15 commits into
Conversation
|
@jAnirudh can you rebase your branch on the latest? Once this looks good, I can update the qss chems as well. |
|
Just a thought: as this work will be implemented over a series of PRs, maybe it would be helpful to open an issue to track the progress and plans, similar to what we did here: #446 |
@baperry2 Sure, I'll put together a plan and open an issue. Meanwhile, @marchdf could you please regenerate the qss mechanisms for me? The qss files are still somehow changing on my linux box. |
|
@nickwimer and @jAnirudh Does this diff look right for the QSS mech? I am a little confused by the numbers. Actually maybe it's ok. Though I would want a second pair of eyes on this. I pushed the changes if you want to see them all.
|
I had introduced |
|
@jAnirudh and @nickwimer I regenerated the QSS mechs with the latest. Feels like we need to confirm that all is well. |
|
Hi @marchdf @baperry2 @nickwimer could you please share your comments on this PR for review/merge? Also tagging @ndeak here. Thanks. |


Reworked the
CEPTRmodules generatingmechanism.cppto work with heterogeneous reaction mechanisms.ck.py:ckncf,cksyme_str,cksyms_str,ckkfkrproduction.py:progress_rate_frutilities.py: Addedget_function_prefix,get_phase,def get_element_id,get_atomic_weight,get_element_namesmethodsNUM_QSS_GAS_SPECIESpreprocessor directive toconverter.pyalong with changes corresponding to above additions/modifications