Skip to content

Spray: only fully vaporize if dropT > max(boilT) - #671

Merged
d-montgomery merged 6 commits into
Pele-Suite:developmentfrom
d-montgomery:boiling-temp
May 20, 2026
Merged

Spray: only fully vaporize if dropT > max(boilT)#671
d-montgomery merged 6 commits into
Pele-Suite:developmentfrom
d-montgomery:boiling-temp

Conversation

@d-montgomery

Copy link
Copy Markdown
Collaborator

In Drag.H particles were considered fully vaporized when the droplet temperature exceeded the estimated mixture boiling temp. However, for multicomponent fuels this lead to premature total vaporization. The existing SingleDrop tests have relatively low temperatures so this never came up.

@d-montgomery
d-montgomery requested a review from baperry2 April 23, 2026 22:57
@d-montgomery
d-montgomery marked this pull request as draft May 4, 2026 16:33
@d-montgomery

Copy link
Copy Markdown
Collaborator Author

After some testing with the new Burger et al. validation case Pele-Suite/PeleLMeX#660, I am okay with removing the droplet temperature check entirely and relying on mass only.

@d-montgomery
d-montgomery requested a review from SreejithNREL May 12, 2026 16:33
@d-montgomery
d-montgomery marked this pull request as ready for review May 18, 2026 15:00

@SreejithNREL SreejithNREL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code fix looks good to me. Using 'boilT_mix' as a hard cut-off criterion is fragile for multicomponent fuels, where preferential evaporation can result in individual component temperature shooting above boilT_mix while the droplet is active. Nice catch!
I see the following code changes:

  1. fixed the criterion to new_mass > min_mass alone
  2. removed old, unused variable Tboil, and
  3. updated documentation (including mentioning why the 50 bar case is not being evaluated at present)
    All looks good to me.

Approving.

@d-montgomery
d-montgomery merged commit 9a21bed into Pele-Suite:development May 20, 2026
14 checks passed
@d-montgomery
d-montgomery deleted the boiling-temp branch May 20, 2026 16:48
@baperry2

Copy link
Copy Markdown
Contributor

What happens now when the droplet temperature exceeds the boiling point in a single component case? This is a semi-nonphysical condition (superheating is possible, but shouldn't happen to excessive amounts), so just want to double check that the code won't crash/do something crazy after this modification.

@d-montgomery

Copy link
Copy Markdown
Collaborator Author

What happens now when the droplet temperature exceeds the boiling point in a single component case? This is a semi-nonphysical condition (superheating is possible, but shouldn't happen to excessive amounts), so just want to double check that the code won't crash/do something crazy after this modification.

I ran the WongLin and Nomura tests out until the drops vaporized without issue. In both cases the gas temperature is much higher than the boiling point of droplet. Here are the results from the WongLin test:
WongLin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants