Make CEPTR code generation fully deterministic - #679
Draft
terencelehmann wants to merge 1 commit into
Draft
Conversation
Sort set-to-list conversions in intersection(), identify_qssa_coupling(), and free_symbols iterations (species_info.py, symbolic_math.py) so that output is stable across Python hash seeds and dependency versions. Set PYTHONHASHSEED=0 in the CEPTR CI job to fix SymEngine CSE variable numbering, which otherwise varies with hash randomization.
Collaborator
|
Thanks for working on this, Terance. If you get a chance, and can figure a way to do it, is it possible to add a CI test that confirms that the results will be deterministic? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CEPTR code generation can produce trivially different (but equivalent) output
across runs when
PYTHONHASHSEEDvaries, causing the CI diff-check to flagspurious changes, as mentioned in #659 . This PR aims to fix the sources of non-determinism in the generator:
intersection()inutilities.py: replacelist(set(...))withsorted(...)identify_qssa_coupling()inqssa_reduction.py: same fix for the deduplication stepfree_symbolsiterations inspecies_info.pyandsymbolic_math.py: sort bystrbefore iteratingCEPTRjob: setPYTHONHASHSEED: 0to fix SymEngine CSE variable numbering,which otherwise varies with Python's hash randomization
All four existing tests pass.
Co-authored by: Claude Sonnet 4.6 noreply@anthropic.com