Skip to content

Add change detection to CI to limit testing requirements - #688

Open
d-montgomery wants to merge 7 commits into
Pele-Suite:developmentfrom
d-montgomery:test-reduced-ci
Open

Add change detection to CI to limit testing requirements#688
d-montgomery wants to merge 7 commits into
Pele-Suite:developmentfrom
d-montgomery:test-reduced-ci

Conversation

@d-montgomery

@d-montgomery d-montgomery commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Testing to see if the updated CI from #687 is working

@d-montgomery

Copy link
Copy Markdown
Collaborator Author

The changes from #687 worked but the branch protection rules for the development branch results in the remaining tests being listed as "required."

@d-montgomery d-montgomery changed the title Test changes to an rst and Utility/*.py file Add change detection to CI to limit testing requirements Aug 11, 2026
@d-montgomery
d-montgomery requested a review from baperry2 August 11, 2026 16:27
@d-montgomery

Copy link
Copy Markdown
Collaborator Author

@baperry2, the changes made in #687 were a good start but the testing still showed many of the tests as "required." I've added a new Detect-Changes test to ci.yml and downstream.yml that can be used as a conditional based on the types of files that have been changed. This provides a little more flexibility than the previous PR and enables PelePhysics-CI/Codespell to run when changes have been made to Docs or python scripts.

@d-montgomery
d-montgomery requested a lite review from Copilot and removed request for baperry2 August 18, 2026 17:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI configuration to use an explicit “Detect-Changes” job (via dorny/paths-filter) and then conditionally runs heavier jobs only when non-doc/non-utility changes are present, instead of relying on paths-ignore at the workflow trigger level.

Changes:

  • Added a Detect-Changes job to compute whether “source” changes are present.
  • Gated downstream/CI jobs behind needs: Detect-Changes and an if: condition based on the computed output.
  • Adjusted CI job dependencies (e.g., Codespell) to depend on change detection rather than formatting.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/downstream.yml Adds change detection and conditionally runs downstream validation jobs based on detected changes.
.github/workflows/ci.yml Adds change detection and conditionally runs most CI jobs based on detected changes; updates job dependencies accordingly.
Suppressed comments (3)

.github/workflows/downstream.yml:86

  • needs.Detect-Changes.outputs.has-source-changes is not valid GitHub Actions expression syntax because both the job id and output name contain -. This will fail to parse (hyphens are treated as operators). Use bracket notation (or rename the ids) when accessing needs/outputs.
    if: needs.Detect-Changes.outputs.has-source-changes == 'true'

.github/workflows/ci.yml:73

  • needs.Detect-Changes.outputs.has-source-changes is not valid GitHub Actions expression syntax because both the job id and output name contain -. This will fail to parse (hyphens are treated as operators). Use bracket notation (or rename the ids) when accessing needs/outputs.
    if: needs.Detect-Changes.outputs.has-source-changes == 'true'

.github/workflows/ci.yml:109

  • needs.Detect-Changes.outputs.has-source-changes is not valid GitHub Actions expression syntax because both the job id and output name contain -. This will fail to parse (hyphens are treated as operators). Use bracket notation (or rename the ids) when accessing needs/outputs.
    if: needs.Detect-Changes.outputs.has-source-changes == 'true'

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/downstream.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/downstream.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/downstream.yml Outdated

PeleC-PMF:
needs: Detect-Changes
if: needs.Detect-Changes.outputs.has-source-changes == 'true'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot change this to needs['Detect-Changes'].outputs['has-source-changes'] == 'true' for consistency with all other instances. Add to current pending batch commit

d-montgomery and others added 2 commits August 18, 2026 11:20
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants