Add change detection to CI to limit testing requirements - #688
Add change detection to CI to limit testing requirements#688d-montgomery wants to merge 7 commits into
Conversation
|
The changes from #687 worked but the branch protection rules for the development branch results in the remaining tests being listed as "required." |
|
@baperry2, the changes made in #687 were a good start but the testing still showed many of the tests as "required." I've added a new |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions CI configuration to use an explicit “Detect-Changes” job (via dorny/paths-filter) and then conditionally runs heavier jobs only when non-doc/non-utility changes are present, instead of relying on paths-ignore at the workflow trigger level.
Changes:
- Added a
Detect-Changesjob to compute whether “source” changes are present. - Gated downstream/CI jobs behind
needs: Detect-Changesand anif:condition based on the computed output. - Adjusted CI job dependencies (e.g.,
Codespell) to depend on change detection rather than formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/downstream.yml | Adds change detection and conditionally runs downstream validation jobs based on detected changes. |
| .github/workflows/ci.yml | Adds change detection and conditionally runs most CI jobs based on detected changes; updates job dependencies accordingly. |
Suppressed comments (3)
.github/workflows/downstream.yml:86
needs.Detect-Changes.outputs.has-source-changesis not valid GitHub Actions expression syntax because both the job id and output name contain-. This will fail to parse (hyphens are treated as operators). Use bracket notation (or rename the ids) when accessingneeds/outputs.
if: needs.Detect-Changes.outputs.has-source-changes == 'true'
.github/workflows/ci.yml:73
needs.Detect-Changes.outputs.has-source-changesis not valid GitHub Actions expression syntax because both the job id and output name contain-. This will fail to parse (hyphens are treated as operators). Use bracket notation (or rename the ids) when accessingneeds/outputs.
if: needs.Detect-Changes.outputs.has-source-changes == 'true'
.github/workflows/ci.yml:109
needs.Detect-Changes.outputs.has-source-changesis not valid GitHub Actions expression syntax because both the job id and output name contain-. This will fail to parse (hyphens are treated as operators). Use bracket notation (or rename the ids) when accessingneeds/outputs.
if: needs.Detect-Changes.outputs.has-source-changes == 'true'
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| PeleC-PMF: | ||
| needs: Detect-Changes | ||
| if: needs.Detect-Changes.outputs.has-source-changes == 'true' |
There was a problem hiding this comment.
@copilot change this to needs['Detect-Changes'].outputs['has-source-changes'] == 'true' for consistency with all other instances. Add to current pending batch commit
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Testing to see if the updated CI from #687 is working